Skip to content

Commit 8c8cb1d

Browse files
kevinelliottclaude
andcommitted
Downgrade golangci-lint action to v6 to support v1.x
golangci-lint-action@v6 supports golangci-lint v1.x golangci-lint-action@v8 requires v2.x which has breaking config changes Downgrading to v6 allows us to use stable v1.x release Removed version field from .golangci.yml (not needed for v1.x) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 70374a1 commit 8c8cb1d

3 files changed

Lines changed: 7 additions & 8 deletions

File tree

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
go-version: '1.24'
6464

6565
- name: Run golangci-lint
66-
uses: golangci/golangci-lint-action@v8
66+
uses: golangci/golangci-lint-action@v6
6767
with:
6868
version: latest
6969
args: --timeout=5m

.golangci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
version: 2
21
run:
32
timeout: 5m
43
tests: true

CLAUDE.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@ AgentPipe is a CLI and TUI application that orchestrates conversations between m
2424
### CI/CD Configuration
2525

2626
#### Linting
27-
- Use golangci-lint-action@v8 with golangci-lint v1.64.8 (stable v1.x)
28-
- GitHub Action version parameter: `version: v1.64.8` (pinned for reproducibility)
29-
- **IMPORTANT**: Config file (`.golangci.yml`) uses v1.x format (no version field required)
27+
- Use golangci-lint-action@v6 with golangci-lint v1.x (latest stable)
28+
- GitHub Action version parameter: `version: latest` (downloads latest v1.x)
29+
- **IMPORTANT**: Config file (`.golangci.yml`) uses v1.x format (no version field)
3030
- **Note**: Removed `nakedret` linter (removed in v2.x, compatible with v1.x)
31-
- **Status**: v2.5.0 (latest) has config compatibility issues; v1.64.8 is stable
32-
- **Local linting**: Install golangci-lint v1.64.8
31+
- **Status**: v2.x requires config schema changes; staying on v1.x is more stable
32+
- **Local linting**: Install latest golangci-lint v1.x
3333
- Install: `brew install golangci-lint`
34-
- Or: `go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.8`
34+
- Or: `go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest`
3535
- Configuration structure: `linters-settings:` for linter config, `issues.exclude-rules:` for exclusions
3636
- Cognitive complexity threshold: 30
3737
- Excluded from complexity checks: pkg/tui/, pkg/adapters/, pkg/orchestrator/

0 commit comments

Comments
 (0)