fix: resolve all linting issues and Windows CI failures

- Fix errcheck: handle error returns for viper.BindPFlag, Process.Kill, and file operations
- Fix duplicate code: extract common BuildAgentPrompt function
- Fix deprecated methods: update viewport scroll methods (LineUp→ScrollUp, etc.)
- Fix Windows test command: remove multiline syntax that breaks on Windows
- Fix formatting: run gofmt and goimports on all Go files

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: kevinelliott

.github/workflows/test.yml

@@ -41,8 +41,7 @@ jobs:
         run: go mod download
 
       - name: Run tests
-        run: |
-          go test -v -race -coverprofile=coverage.txt -covermode=atomic ./...
+        run: go test -v -race -coverprofile=coverage.txt -covermode=atomic ./...
 
       - name: Build
         run: go build -v ./...

cmd/root.go

@@ -31,7 +31,9 @@ func init() {
 	rootCmd.PersistentFlags().StringVar(&cfgFile, "config", "", "config file (default is $HOME/.agentpipe.yaml)")
 	rootCmd.PersistentFlags().Bool("verbose", false, "Enable verbose output")
 
-	_ = viper.BindPFlag("verbose", rootCmd.PersistentFlags().Lookup("verbose"))
+	if err := viper.BindPFlag("verbose", rootCmd.PersistentFlags().Lookup("verbose")); err != nil {
+		fmt.Fprintf(os.Stderr, "Error binding verbose flag: %v\n", err)
+	}
 }
 
 func initConfig() {

pkg/adapters/claude.go

@@ -142,23 +142,7 @@ func (c *ClaudeAgent) formatConversation(messages []agent.Message) string {
 }
 
 func (c *ClaudeAgent) buildPrompt(conversation string) string {
-	var prompt strings.Builder
-
-	prompt.WriteString("You are participating in a multi-agent conversation. ")
-	prompt.WriteString(fmt.Sprintf("Your name is '%s'. ", c.Name))
-
-	if c.Config.Prompt != "" {
-		prompt.WriteString(c.Config.Prompt)
-		prompt.WriteString("\n\n")
-	}
-
-	prompt.WriteString("Here is the conversation so far:\n\n")
-	prompt.WriteString(conversation)
-	prompt.WriteString("\n\nContinue the conversation naturally as ")
-	prompt.WriteString(c.Name)
-	prompt.WriteString(". Build on what was just said without repeating previous points. Don't announce that you're joining - just respond directly:")
-
-	return prompt.String()
+	return BuildAgentPrompt(c.Name, c.Config.Prompt, conversation)
 }
 
 func init() {

pkg/adapters/common.go

@@ -0,0 +1,27 @@
+package adapters
+
+import (
+	"fmt"
+	"strings"
+)
+
+// BuildAgentPrompt creates a standard prompt for multi-agent conversations
+func BuildAgentPrompt(agentName string, customPrompt string, conversation string) string {
+	var prompt strings.Builder
+
+	prompt.WriteString("You are participating in a multi-agent conversation. ")
+	prompt.WriteString(fmt.Sprintf("Your name is '%s'. ", agentName))
+
+	if customPrompt != "" {
+		prompt.WriteString(customPrompt)
+		prompt.WriteString("\n\n")
+	}
+
+	prompt.WriteString("Here is the conversation so far:\n\n")
+	prompt.WriteString(conversation)
+	prompt.WriteString("\n\nContinue the conversation naturally as ")
+	prompt.WriteString(agentName)
+	prompt.WriteString(". Build on what was just said without repeating previous points. Don't announce that you're joining - just respond directly:")
+
+	return prompt.String()
+}

pkg/adapters/gemini.go

@@ -57,7 +57,10 @@ func (g *GeminiAgent) HealthCheck(ctx context.Context) error {
 		if err := testCmd.Start(); err != nil {
 			return fmt.Errorf("gemini CLI cannot be executed: %w", err)
 		}
-		_ = testCmd.Process.Kill()
+		if err := testCmd.Process.Kill(); err != nil {
+			// Process might have already exited, which is fine
+			return nil
+		}
 		// If we can start it, consider it healthy
 		return nil
 	}
@@ -196,23 +199,7 @@ func (g *GeminiAgent) formatConversation(messages []agent.Message) string {
 }
 
 func (g *GeminiAgent) buildPrompt(conversation string) string {
-	var prompt strings.Builder
-
-	prompt.WriteString("You are participating in a multi-agent conversation. ")
-	prompt.WriteString(fmt.Sprintf("Your name is '%s'. ", g.Name))
-
-	if g.Config.Prompt != "" {
-		prompt.WriteString(g.Config.Prompt)
-		prompt.WriteString("\n\n")
-	}
-
-	prompt.WriteString("Here is the conversation so far:\n\n")
-	prompt.WriteString(conversation)
-	prompt.WriteString("\n\nContinue the conversation naturally as ")
-	prompt.WriteString(g.Name)
-	prompt.WriteString(". Build on what was just said without repeating previous points. Don't announce that you're joining - just respond directly:")
-
-	return prompt.String()
+	return BuildAgentPrompt(g.Name, g.Config.Prompt, conversation)
 }
 
 func init() {

pkg/adapters/qwen.go

@@ -58,7 +58,10 @@ func (q *QwenAgent) HealthCheck(ctx context.Context) error {
 			if err := testCmd.Start(); err != nil {
 				return fmt.Errorf("qwen CLI cannot be executed: %w", err)
 			}
-			_ = testCmd.Process.Kill()
+			if err := testCmd.Process.Kill(); err != nil {
+				// Process might have already exited, which is fine
+				return nil
+			}
 			// If we can start it, consider it healthy
 			return nil
 		}

pkg/logger/logger.go

@@ -311,8 +311,12 @@ func (l *ChatLogger) wrapText(text string, indent int) string {
 
 func (l *ChatLogger) writeToFile(content string) {
 	if l.logFile != nil {
-		_, _ = l.logFile.WriteString(content)
-		_ = l.logFile.Sync()
+		if _, err := l.logFile.WriteString(content); err != nil {
+			fmt.Fprintf(os.Stderr, "Error writing to log file: %v\n", err)
+		}
+		if err := l.logFile.Sync(); err != nil {
+			fmt.Fprintf(os.Stderr, "Error syncing log file: %v\n", err)
+		}
 	}
 }
 

pkg/tui/enhanced.go

@@ -224,24 +224,24 @@ func (m EnhancedModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 			if m.activePanel == agentsPanel {
 				m.agentList, _ = m.agentList.Update(msg)
 			} else if m.activePanel == conversationPanel {
-				m.conversation.LineUp(1)
+				m.conversation.ScrollUp(1)
 			}
 
 		case "down", "j":
 			if m.activePanel == agentsPanel {
 				m.agentList, _ = m.agentList.Update(msg)
 			} else if m.activePanel == conversationPanel {
-				m.conversation.LineDown(1)
+				m.conversation.ScrollDown(1)
 			}
 
 		case "pgup":
 			if m.activePanel == conversationPanel {
-				m.conversation.HalfViewUp()
+				m.conversation.HalfPageUp()
 			}
 
 		case "pgdown":
 			if m.activePanel == conversationPanel {
-				m.conversation.HalfViewDown()
+				m.conversation.HalfPageDown()
 			}
 		}