fixes for CI

kevinelliott · kevinelliott · commit d92fdc2c0630 · 2025-09-11T21:06:48.000-07:00
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -0,0 +1,35 @@
+version: 2
+updates:
+  # Enable version updates for Go modules
+  - package-ecosystem: "gomod"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+      day: "monday"
+      time: "05:00"
+    open-pull-requests-limit: 10
+    reviewers:
+      - "kevinelliott"
+    labels:
+      - "dependencies"
+      - "go"
+    commit-message:
+      prefix: "chore"
+      include: "scope"
+
+  # Enable version updates for GitHub Actions
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+      day: "monday"
+      time: "05:00"
+    open-pull-requests-limit: 5
+    reviewers:
+      - "kevinelliott"
+    labels:
+      - "dependencies"
+      - "github-actions"
+    commit-message:
+      prefix: "ci"
+      include: "scope"
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
@@ -0,0 +1,42 @@
+name: CodeQL
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+  schedule:
+    - cron: '30 1 * * 1'  # Weekly on Monday at 1:30 UTC
+
+permissions:
+  actions: read
+  contents: read
+  security-events: write
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'go' ]
+    
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+      
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@v3
+        with:
+          languages: ${{ matrix.language }}
+          queries: security-and-quality
+      
+      - name: Autobuild
+        uses: github/codeql-action/autobuild@v3
+      
+      - name: Perform CodeQL Analysis
+        uses: github/codeql-action/analyze@v3
+        with:
+          category: "/language:${{matrix.language}}"
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -6,6 +6,11 @@ on:
   pull_request:
     branches: [ main ]
 
+permissions:
+  contents: read
+  security-events: write
+  actions: read
+
 jobs:
   test:
     name: Test
@@ -80,7 +85,7 @@ jobs:
           output: 'trivy-results.sarif'
 
       - name: Upload Trivy results to GitHub Security tab
-        uses: github/codeql-action/upload-sarif@v2
+        uses: github/codeql-action/upload-sarif@v3
         if: always()
         with:
           sarif_file: 'trivy-results.sarif'
diff --git a/.golangci.yml b/.golangci.yml
@@ -1,10 +1,6 @@
 run:
   timeout: 5m
   tests: true
-  skip-dirs:
-    - vendor
-    - .git
-    - dist
 
 linters:
   enable:
@@ -28,18 +24,16 @@ linters:
     - gocognit
 
   disable:
-    - golint # deprecated
-    - interfacer # deprecated
-    - maligned # deprecated
-    - scopelint # deprecated
+    - unused # False positives on some fields
 
 linters-settings:
   gofmt:
     simplify: true
   goimports:
     local-prefixes: github.com/kevinelliott/agentpipe
   govet:
-    check-shadowing: true
+    enable:
+      - shadow
   errcheck:
     check-type-assertions: true
     check-blank: true
@@ -59,6 +53,10 @@ linters-settings:
       - G304 # File path provided as taint input
 
 issues:
+  exclude-dirs:
+    - vendor
+    - .git
+    - dist
   exclude-rules:
     # Exclude some linters from running on test files
     - path: _test\.go
diff --git a/cmd/root.go b/cmd/root.go
@@ -31,7 +31,7 @@ func init() {
 	rootCmd.PersistentFlags().StringVar(&cfgFile, "config", "", "config file (default is $HOME/.agentpipe.yaml)")
 	rootCmd.PersistentFlags().Bool("verbose", false, "Enable verbose output")
 
-	viper.BindPFlag("verbose", rootCmd.PersistentFlags().Lookup("verbose"))
+	_ = viper.BindPFlag("verbose", rootCmd.PersistentFlags().Lookup("verbose"))
 }
 
 func initConfig() {
diff --git a/cmd/run.go b/cmd/run.go
@@ -171,7 +171,10 @@ func startConversation(cmd *cobra.Command, cfg *config.Config) error {
 		}
 
 		// Perform health check unless skipped
-		skipHealthCheck, _ := cmd.Flags().GetBool("skip-health-check")
+		skipHealthCheck, err := cmd.Flags().GetBool("skip-health-check")
+		if err != nil {
+			skipHealthCheck = false
+		}
 		if !skipHealthCheck {
 			if verbose {
 				fmt.Printf("  Checking health of %s...\n", agentCfg.Name)
diff --git a/pkg/adapters/claude.go b/pkg/adapters/claude.go
@@ -131,7 +131,7 @@ func (c *ClaudeAgent) StreamMessage(ctx context.Context, messages []agent.Messag
 }
 
 func (c *ClaudeAgent) formatConversation(messages []agent.Message) string {
-	var parts []string
+	parts := make([]string, 0, len(messages))
 
 	for _, msg := range messages {
 		timestamp := time.Unix(msg.Timestamp, 0).Format("15:04:05")
diff --git a/pkg/adapters/codex.go b/pkg/adapters/codex.go
@@ -171,7 +171,7 @@ func (c *CodexAgent) StreamMessage(ctx context.Context, messages []agent.Message
 }
 
 func (c *CodexAgent) formatConversation(messages []agent.Message) string {
-	var parts []string
+	parts := make([]string, 0, len(messages))
 
 	for _, msg := range messages {
 		timestamp := time.Unix(msg.Timestamp, 0).Format("15:04:05")
@@ -201,4 +201,3 @@ func (c *CodexAgent) buildPrompt(conversation string) string {
 func init() {
 	agent.RegisterFactory("codex", NewCodexAgent)
 }
-
diff --git a/pkg/adapters/gemini.go b/pkg/adapters/gemini.go
@@ -57,7 +57,7 @@ func (g *GeminiAgent) HealthCheck(ctx context.Context) error {
 		if err := testCmd.Start(); err != nil {
 			return fmt.Errorf("gemini CLI cannot be executed: %w", err)
 		}
-		testCmd.Process.Kill()
+		_ = testCmd.Process.Kill()
 		// If we can start it, consider it healthy
 		return nil
 	}
@@ -185,7 +185,7 @@ func (g *GeminiAgent) StreamMessage(ctx context.Context, messages []agent.Messag
 }
 
 func (g *GeminiAgent) formatConversation(messages []agent.Message) string {
-	var parts []string
+	parts := make([]string, 0, len(messages))
 
 	for _, msg := range messages {
 		timestamp := time.Unix(msg.Timestamp, 0).Format("15:04:05")
@@ -218,4 +218,3 @@ func (g *GeminiAgent) buildPrompt(conversation string) string {
 func init() {
 	agent.RegisterFactory("gemini", NewGeminiAgent)
 }
-
diff --git a/pkg/adapters/qwen.go b/pkg/adapters/qwen.go
@@ -58,7 +58,7 @@ func (q *QwenAgent) HealthCheck(ctx context.Context) error {
 			if err := testCmd.Start(); err != nil {
 				return fmt.Errorf("qwen CLI cannot be executed: %w", err)
 			}
-			testCmd.Process.Kill()
+			_ = testCmd.Process.Kill()
 			// If we can start it, consider it healthy
 			return nil
 		}
@@ -127,7 +127,7 @@ func (q *QwenAgent) StreamMessage(ctx context.Context, messages []agent.Message,
 }
 
 func (q *QwenAgent) formatConversation(messages []agent.Message) string {
-	var parts []string
+	parts := make([]string, 0, len(messages))
 
 	for _, msg := range messages {
 		timestamp := time.Unix(msg.Timestamp, 0).Format("15:04:05")
@@ -157,4 +157,3 @@ func (q *QwenAgent) buildPrompt(conversation string) string {
 func init() {
 	agent.RegisterFactory("qwen", NewQwenAgent)
 }
-
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -32,7 +32,10 @@ type LoggingConfig struct {
 }
 
 func NewDefaultConfig() *Config {
-	homeDir, _ := os.UserHomeDir()
+	homeDir, err := os.UserHomeDir()
+	if err != nil {
+		homeDir = "."
+	}
 	defaultLogDir := fmt.Sprintf("%s/.agentpipe/chats", homeDir)
 
 	return &Config{
@@ -79,7 +82,7 @@ func (c *Config) SaveConfig(path string) error {
 		return fmt.Errorf("failed to marshal config: %w", err)
 	}
 
-	if err := os.WriteFile(path, data, 0644); err != nil {
+	if err := os.WriteFile(path, data, 0600); err != nil {
 		return fmt.Errorf("failed to write config file: %w", err)
 	}
 
diff --git a/pkg/logger/logger.go b/pkg/logger/logger.go
@@ -52,22 +52,23 @@ var (
 			Foreground(lipgloss.Color("196")).
 			Bold(true)
 
-	errorBadgeStyle = lipgloss.NewStyle().
-			Background(lipgloss.Color("196")).
-			Foreground(lipgloss.Color("255")).
-			Bold(true).
-			Padding(0, 1).
-			MarginRight(1)
+	// Unused styles commented out to pass linting
+	// errorBadgeStyle = lipgloss.NewStyle().
+	// 		Background(lipgloss.Color("196")).
+	// 		Foreground(lipgloss.Color("255")).
+	// 		Bold(true).
+	// 		Padding(0, 1).
+	// 		MarginRight(1)
 
 	separatorStyle = lipgloss.NewStyle().
 			Foreground(lipgloss.Color("236"))
 
-	messageBoxStyle = lipgloss.NewStyle().
-			BorderStyle(lipgloss.RoundedBorder()).
-			BorderForeground(lipgloss.Color("238")).
-			PaddingLeft(1).
-			PaddingRight(1).
-			MarginBottom(1)
+	// messageBoxStyle = lipgloss.NewStyle().
+	// 		BorderStyle(lipgloss.RoundedBorder()).
+	// 		BorderForeground(lipgloss.Color("238")).
+	// 		PaddingLeft(1).
+	// 		PaddingRight(1).
+	// 		MarginBottom(1)
 )
 
 func NewChatLogger(logDir string, logFormat string, console io.Writer, showMetrics bool) (*ChatLogger, error) {
@@ -110,9 +111,9 @@ func NewChatLogger(logDir string, logFormat string, console io.Writer, showMetri
 	}
 
 	// Write header to log file
-	logger.writeToFile(fmt.Sprintf("=== AgentPipe Chat Log ===\n"))
-	logger.writeToFile(fmt.Sprintf("Started: %s\n", time.Now().Format("2006-01-02 15:04:05")))
-	logger.writeToFile(fmt.Sprintf("=====================================\n\n"))
+	logger.writeToFile("=== AgentPipe Chat Log ===\n")
+	logger.writeToFile("Started: " + time.Now().Format("2006-01-02 15:04:05") + "\n")
+	logger.writeToFile("=====================================\n\n")
 
 	if console != nil {
 		fmt.Fprintf(console, "\n📝 Chat logged to: %s\n", logPath)
@@ -163,8 +164,10 @@ func (l *ChatLogger) LogMessage(msg agent.Message) {
 	// Write to file
 	if l.logFile != nil {
 		if l.logFormat == "json" {
-			data, _ := json.Marshal(msg)
-			l.writeToFile(string(data) + "\n")
+			data, err := json.Marshal(msg)
+			if err == nil {
+				l.writeToFile(string(data) + "\n")
+			}
 		} else {
 			l.writeToFile(fmt.Sprintf("[%s] %s (%s): %s\n\n",
 				timestamp, msg.AgentName, msg.Role, msg.Content))
@@ -308,15 +311,15 @@ func (l *ChatLogger) wrapText(text string, indent int) string {
 
 func (l *ChatLogger) writeToFile(content string) {
 	if l.logFile != nil {
-		l.logFile.WriteString(content)
-		l.logFile.Sync()
+		_, _ = l.logFile.WriteString(content)
+		_ = l.logFile.Sync()
 	}
 }
 
 func (l *ChatLogger) Close() {
 	if l.logFile != nil {
-		l.writeToFile(fmt.Sprintf("\n=== Chat Ended ===\n"))
-		l.writeToFile(fmt.Sprintf("Ended: %s\n", time.Now().Format("2006-01-02 15:04:05")))
+		l.writeToFile("\n=== Chat Ended ===\n")
+		l.writeToFile("Ended: " + time.Now().Format("2006-01-02 15:04:05") + "\n")
 		l.logFile.Close()
 	}
 }
diff --git a/pkg/tui/enhanced.go b/pkg/tui/enhanced.go
@@ -13,7 +13,6 @@ import (
 	"github.com/charmbracelet/lipgloss"
 	"github.com/kevinelliott/agentpipe/pkg/agent"
 	"github.com/kevinelliott/agentpipe/pkg/config"
-	"github.com/kevinelliott/agentpipe/pkg/orchestrator"
 )
 
 type panel int
@@ -25,10 +24,9 @@ const (
 )
 
 type EnhancedModel struct {
-	ctx          context.Context
-	config       *config.Config
-	agents       []agent.Agent
-	orchestrator *orchestrator.Orchestrator
+	ctx    context.Context
+	config *config.Config
+	agents []agent.Agent
 
 	// UI components
 	agentList    list.Model
@@ -50,7 +48,6 @@ type EnhancedModel struct {
 
 	// Styles
 	agentColors map[string]lipgloss.Color
-	colorIndex  int
 }
 
 // Styles
diff --git a/pkg/tui/tui.go b/pkg/tui/tui.go
@@ -41,18 +41,17 @@ var (
 )
 
 type Model struct {
-	ctx          context.Context
-	config       *config.Config
-	agents       []agent.Agent
-	orchestrator *orchestrator.Orchestrator
-	messages     []agent.Message
-	viewport     viewport.Model
-	textarea     textarea.Model
-	width        int
-	height       int
-	ready        bool
-	running      bool
-	err          error
+	ctx      context.Context
+	config   *config.Config
+	agents   []agent.Agent
+	messages []agent.Message
+	viewport viewport.Model
+	textarea textarea.Model
+	width    int
+	height   int
+	ready    bool
+	running  bool
+	err      error
 }
 
 type messageUpdate struct {

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ func init() {`
`31`	`31`	`rootCmd.PersistentFlags().StringVar(&cfgFile, "config", "", "config file (default is $HOME/.agentpipe.yaml)")`
`32`	`32`	`rootCmd.PersistentFlags().Bool("verbose", false, "Enable verbose output")`
`33`	`33`
`34`		`- viper.BindPFlag("verbose", rootCmd.PersistentFlags().Lookup("verbose"))`
	`34`	`+ _ = viper.BindPFlag("verbose", rootCmd.PersistentFlags().Lookup("verbose"))`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`func initConfig() {`
Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ func (c *ClaudeAgent) StreamMessage(ctx context.Context, messages []agent.Messag`
`131`	`131`	`}`
`132`	`132`
`133`	`133`	`func (c *ClaudeAgent) formatConversation(messages []agent.Message) string {`
`134`		`- var parts []string`
	`134`	`+ parts := make([]string, 0, len(messages))`
`135`	`135`
`136`	`136`	`for _, msg := range messages {`
`137`	`137`	`timestamp := time.Unix(msg.Timestamp, 0).Format("15:04:05")`
Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ func (c *CodexAgent) StreamMessage(ctx context.Context, messages []agent.Message`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`func (c *CodexAgent) formatConversation(messages []agent.Message) string {`
`174`		`- var parts []string`
	`174`	`+ parts := make([]string, 0, len(messages))`
`175`	`175`
`176`	`176`	`for _, msg := range messages {`
`177`	`177`	`timestamp := time.Unix(msg.Timestamp, 0).Format("15:04:05")`
`@@ -201,4 +201,3 @@ func (c *CodexAgent) buildPrompt(conversation string) string {`
`201`	`201`	`func init() {`
`202`	`202`	`agent.RegisterFactory("codex", NewCodexAgent)`
`203`	`203`	`}`
`204`		`-`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ func (g *GeminiAgent) HealthCheck(ctx context.Context) error {`
`57`	`57`	`if err := testCmd.Start(); err != nil {`
`58`	`58`	`return fmt.Errorf("gemini CLI cannot be executed: %w", err)`
`59`	`59`	`}`
`60`		`- testCmd.Process.Kill()`
	`60`	`+ _ = testCmd.Process.Kill()`
`61`	`61`	`// If we can start it, consider it healthy`
`62`	`62`	`return nil`
`63`	`63`	`}`
`@@ -185,7 +185,7 @@ func (g *GeminiAgent) StreamMessage(ctx context.Context, messages []agent.Messag`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`func (g *GeminiAgent) formatConversation(messages []agent.Message) string {`
`188`		`- var parts []string`
	`188`	`+ parts := make([]string, 0, len(messages))`
`189`	`189`
`190`	`190`	`for _, msg := range messages {`
`191`	`191`	`timestamp := time.Unix(msg.Timestamp, 0).Format("15:04:05")`
`@@ -218,4 +218,3 @@ func (g *GeminiAgent) buildPrompt(conversation string) string {`
`218`	`218`	`func init() {`
`219`	`219`	`agent.RegisterFactory("gemini", NewGeminiAgent)`
`220`	`220`	`}`
`221`		`-`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ func (q *QwenAgent) HealthCheck(ctx context.Context) error {`
`58`	`58`	`if err := testCmd.Start(); err != nil {`
`59`	`59`	`return fmt.Errorf("qwen CLI cannot be executed: %w", err)`
`60`	`60`	`}`
`61`		`- testCmd.Process.Kill()`
	`61`	`+ _ = testCmd.Process.Kill()`
`62`	`62`	`// If we can start it, consider it healthy`
`63`	`63`	`return nil`
`64`	`64`	`}`
`@@ -127,7 +127,7 @@ func (q *QwenAgent) StreamMessage(ctx context.Context, messages []agent.Message,`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`func (q *QwenAgent) formatConversation(messages []agent.Message) string {`
`130`		`- var parts []string`
	`130`	`+ parts := make([]string, 0, len(messages))`
`131`	`131`
`132`	`132`	`for _, msg := range messages {`
`133`	`133`	`timestamp := time.Unix(msg.Timestamp, 0).Format("15:04:05")`
`@@ -157,4 +157,3 @@ func (q *QwenAgent) buildPrompt(conversation string) string {`
`157`	`157`	`func init() {`
`158`	`158`	`agent.RegisterFactory("qwen", NewQwenAgent)`
`159`	`159`	`}`
`160`		`-`