Skip to content

Kevinjqliu/update uv lock docs#38

Closed
kevinjqliu wants to merge 6 commits intomainfrom
kevinjqliu/update-uv-lock-docs
Closed

Kevinjqliu/update uv lock docs#38
kevinjqliu wants to merge 6 commits intomainfrom
kevinjqliu/update-uv-lock-docs

Conversation

@kevinjqliu
Copy link
Copy Markdown
Owner

Rationale for this change

Are these changes tested?

Are there any user-facing changes?

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's uv lock file management by integrating the official uv-pre-commit hook, which eliminates the need for custom Makefile targets. Additionally, it updates and pins the datafusion dependency to a specific version, contributing to more consistent dependency resolution and a cleaner build configuration.

Highlights

  • Pre-commit Hook Refactor: The local uv-lock-check pre-commit hook has been replaced with the official uv-pre-commit hook from astral-sh, improving the consistency and reliability of uv lock file validation.
  • Makefile Simplification: The uv-lock and uv-lock-check targets, along with their references, have been removed from the Makefile as their functionality is now handled by the new pre-commit hook.
  • Dependency Update: The datafusion dependency in pyproject.toml has been updated to explicitly pin it to version 52.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .pre-commit-config.yaml
    • Switched from a local uv-lock-check hook to the uv-lock hook from astral-sh/uv-pre-commit.
  • Makefile
    • Removed uv-lock and uv-lock-check targets.
    • Removed uv-lock and uv-lock-check from the help target list.
  • pyproject.toml
    • Updated the datafusion dependency to pin it to version 52.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to improve the uv.lock file management by switching to the official uv-pre-commit hook. This is a good direction. However, I've found two critical issues in the implementation that will cause parts of the development workflow to fail. The uv version specified in .pre-commit-config.yaml is invalid, and the datafusion dependency version in pyproject.toml is also incorrect. My review includes specific comments to address these issues.

Comment thread .pre-commit-config.yaml
- repo: local
- repo: https://github.com/astral-sh/uv-pre-commit
# uv version.
rev: 0.10.9
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The rev 0.10.9 is not a valid uv version. According to the uv-pre-commit documentation, this should be a valid version of uv. uv versions are in the format 0.x.y (e.g., 0.2.2). This will cause the pre-commit hook installation to fail. Please use a valid uv version.

    rev: 0.2.2

Comment thread pyproject.toml Outdated
hf = ["huggingface-hub>=0.24.0"]
pyiceberg-core = ["pyiceberg-core>=0.5.1,<0.9.0"]
datafusion = ["datafusion>=51,<52"]
datafusion = ["datafusion==52"]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version specifier for datafusion appears to be incorrect. The datafusion package on PyPI does not have a version 52; its versions are in the 0.x.y format (e.g., 0.10.0). This change will likely cause dependency resolution to fail for the datafusion extra. Could you please verify the correct package name and version?

@kevinjqliu kevinjqliu closed this Mar 12, 2026
@kevinjqliu kevinjqliu deleted the kevinjqliu/update-uv-lock-docs branch March 12, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant