Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to improve the uv.lock file management by switching to the official uv-pre-commit hook. This is a good direction. However, I've found two critical issues in the implementation that will cause parts of the development workflow to fail. The uv version specified in .pre-commit-config.yaml is invalid, and the datafusion dependency version in pyproject.toml is also incorrect. My review includes specific comments to address these issues.
| - repo: local | ||
| - repo: https://github.com/astral-sh/uv-pre-commit | ||
| # uv version. | ||
| rev: 0.10.9 |
There was a problem hiding this comment.
| hf = ["huggingface-hub>=0.24.0"] | ||
| pyiceberg-core = ["pyiceberg-core>=0.5.1,<0.9.0"] | ||
| datafusion = ["datafusion>=51,<52"] | ||
| datafusion = ["datafusion==52"] |
There was a problem hiding this comment.
The version specifier for datafusion appears to be incorrect. The datafusion package on PyPI does not have a version 52; its versions are in the 0.x.y format (e.g., 0.10.0). This change will likely cause dependency resolution to fail for the datafusion extra. Could you please verify the correct package name and version?
This reverts commit 3cb5d22.
Rationale for this change
Are these changes tested?
Are there any user-facing changes?