try 1.11.0 rc4#42
Open
kevinjqliu wants to merge 14 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
kevinjqliu
force-pushed
the
kevinjqliu/test-iceberg-rc
branch
from
f8cc523 to
b819d4b
Compare
# Rationale for this change - Relates to apache/iceberg#14869 ## Are these changes tested? tests/catalog/test_rest.py contains new tests. ## Are there any user-facing changes? This PR adds a new `register_view` method to `catalog`. <!-- In the case of user-facing changes, please add the changelog label. -->
# Rationale for this change `test_write_optional_list` uses `create_table_if_not_exists` and then asserts exact row counts (2 after the first append, 4 after the second). The table is reused across runs, so a second invocation against the same docker-compose stack accumulates rows — counts become 6, 10, 14, … and the asserts fail. CI hides this because it spins up a fresh `docker-compose-integration` stack for every job. Locally it bites anyone who runs `make test-integration-exec` twice without `make test-integration-cleanup` in between. Fix: drop the table at the start so the test always starts from a clean slate, matching the `drop-then-create` pattern used by `_create_table()` for every other write test in this module. # Are these changes tested? Yes — verified locally that the test now passes when run twice back-to-back without resetting the docker stack: ```bash docker compose -f dev/docker-compose-integration.yml up -d --wait uv run python dev/provision.py uv run python -m pytest tests/integration/test_writes/test_writes.py::test_write_optional_list -m integration # PASS uv run python -m pytest tests/integration/test_writes/test_writes.py::test_write_optional_list -m integration # PASS (was previously: 8 == 2) ``` Full `tests/integration/test_writes/test_writes.py` suite: 122 passed, 1 skipped. # Are there any user-facing changes? No. --- Noticed while preparing the PR for apache#2152 (`RecordBatchReader` streaming append). Co-authored-by: Paul Mathew <paul.mathew@aircall.io>
Closes apache#3328 # Rationale for this change `pyiceberg_example.ipynb` and `spark_integration_example.ipynb` had no automated test coverage. Breaking changes to notebook cells could go undetected in CI. This PR adds papermill-based tests that execute the real notebooks as-is, so any change to a cell is automatically reflected in the tests. ## Are these changes tested? Yes. The tests themselves are the change. Run them with: ```bash make test-notebook ``` ## Are there any user-facing changes? No.
Co-authored-by: Copilot <copilot@github.com>
kevinjqliu
force-pushed
the
kevinjqliu/test-iceberg-rc
branch
from
d3eaa65 to
afecbb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Are these changes tested?
Are there any user-facing changes?