Web improvements for behavior/api call list

[meck-gd]

Since the bootstrap5 update there's been an issue where the active page isn't highlighted, which made it annoying to go through pages because you had to remember the number you clicked last.

While I was at it, I also introduced a change so that the page scrolls to the top pagination above the API list when switching pages. Before, it would always scroll to the very top of the page, which is annoying (the style update made the tree and everything slightly larger at the top of the page, so you had to scroll down quite a bit to see the actual APIs again).

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses user experience issues related to pagination and page scrolling on web interfaces. It ensures that the currently active page in a paginated list is clearly indicated and improves navigation efficiency by automatically adjusting the scroll position when moving between pages.

Highlights

• Pagination Active State: Resolved an issue where the active page in pagination was not visually highlighted after the Bootstrap 5 update, improving navigation clarity.
• Page Scroll Behavior: Implemented a feature to automatically scroll the view to the top pagination bar when switching pages, preventing the need for manual scrolling to find the API list.

Changelog

• web/static/css/style.css
  • Added scroll-margin-top property to the #top_pagination ID to ensure proper spacing when scrolling into view.
  • Updated the background-color for active pagination links with !important to enforce the correct styling.
• web/templates/analysis/behavior/_processes.html
  • Prevented default link behavior for pagination clicks using e.preventDefault().
  • Added functionality to scroll the top pagination element into view when a pagination link is clicked.
• web/templates/analysis/strace/_processes.html
  • Prevented default link behavior for pagination clicks using e.preventDefault().
  • Added functionality to scroll the top pagination element into view when a pagination link is clicked.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces two user experience improvements for paginated API call lists. First, it fixes an issue where the active page was not highlighted in the pagination controls. This was addressed by increasing the specificity of the CSS rule for active page links. Second, it changes the scroll behavior when navigating between pages. Instead of scrolling to the top of the page, it now scrolls to the pagination bar above the list, which is more convenient for the user. The implementation is mostly correct, but I've pointed out a couple of places in the JavaScript code where DOM lookups can be simplified for better readability and minor performance gains.

[kevoreilly]

Thank you very much for this PR, lgtm. What do you make of Gemini's suggestions?

[meck-gd]

Thank you very much for this PR, lgtm. What do you make of Gemini's suggestions?

It was mostly about a line unrelated to my change, but I suppose it's not wrong. I've applied an improve variant of the suggestions.