Skip to content

Add xdg-open package for generic graphical sample detonation on Linux #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevoreilly merged 1 commit into from
Apr 9, 2026
Merged

Add xdg-open package for generic graphical sample detonation on Linux #2966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions analyzer/linux/modules/packages/xdg_open.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#!/usr/bin/env python

from lib.core.packages import Package


class Xdg_open(Package):
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The class name Xdg_open does not follow PEP 8 naming conventions for classes (CapWords). While the current loader logic in lib/core/packages.py uses .capitalize() on the filename, which results in Xdg_open, it would be better to update the loader to handle snake_case to PascalCase conversion properly so that standard naming can be used. If the loader cannot be changed, this is acceptable but inconsistent with Python standards.

References
  1. Class names should normally use the CapWords convention as per PEP 8. (link)

"""Start file with xdg-open"""

summary = "Run via xdg-open"
description = "Generic package that uses xdg-open to run sample"

def prepare(self):
self.args = [self.target] + self.args
self.target = "/usr/bin/xdg-open"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding the path to /usr/bin/xdg-open might fail on distributions where it is located elsewhere (e.g., /bin/xdg-open). It is generally safer to rely on the system PATH or use a utility to locate the binary.

Suggested change
self.target = "/usr/bin/xdg-open"
self.target = "xdg-open"

Loading