Add more paths for Chrome & Chromium packages#2980
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the executable search paths for Google Chrome and Chromium across several analysis packages, including chrome.py, chromium.py, chromium_ext.py, and crx.py, to ensure the browsers are correctly located. The feedback recommends adding Program Files (x86) paths for both browsers to improve robustness and support 32-bit installations on 64-bit Windows environments.
| """Chrome analysis package.""" | ||
|
|
||
| PATHS = [ | ||
| ("LOCALAPPDATA", "Google", "Chrome", "Application", "chrome.exe"), |
There was a problem hiding this comment.
On 64-bit Windows systems, Google Chrome is frequently installed in the Program Files (x86) directory. Adding this path ensures the package can locate the browser in such environments.
| ("LOCALAPPDATA", "Google", "Chrome", "Application", "chrome.exe"), | |
| ("LOCALAPPDATA", "Google", "Chrome", "Application", "chrome.exe"), | |
| ("ProgramFiles(x86)", "Google", "Chrome", "Application", "chrome.exe"), |
| PATHS = [ | ||
| ("LOCALAPPDATA", "Chromium", "Application", "chrome.exe"), | ||
| ("ProgramFiles", "Google", "Chrome", "Application", "chrome.exe"), | ||
| ("ProgramFiles", "Chromium", "Application", "chrome.exe"), |
There was a problem hiding this comment.
| PATHS = [ | ||
| ("LOCALAPPDATA", "Chromium", "chrome.exe"), | ||
| ("LOCALAPPDATA", "Chromium", "Application", "chrome.exe"), | ||
| ("ProgramFiles", "Chromium", "Application", "chrome.exe"), |
| """CRX extensions analysis package.""" | ||
|
|
||
| PATHS = [ | ||
| ("LOCALAPPDATA", "Google", "Chrome", "Application", "chrome.exe"), |
There was a problem hiding this comment.
It is recommended to include the Program Files (x86) path for Google Chrome to support 64-bit Windows environments where the 32-bit version of the browser is installed.
| ("LOCALAPPDATA", "Google", "Chrome", "Application", "chrome.exe"), | |
| ("LOCALAPPDATA", "Google", "Chrome", "Application", "chrome.exe"), | |
| ("ProgramFiles(x86)", "Google", "Chrome", "Application", "chrome.exe"), |
| ("LOCALAPPDATA", "Google", "Chrome", "Application", "chrome.exe"), | ||
| ("ProgramFiles", "Google", "Chrome", "Application", "chrome.exe"), | ||
| ("LOCALAPPDATA", "Chromium", "Application", "chrome.exe"), | ||
| ("ProgramFiles", "Chromium", "Application", "chrome.exe"), |
|
None of the gemini suggestions make sense: CAPEv2/analyzer/windows/lib/common/abstracts.py Lines 112 to 114 in f7a5d7f |
No description provided.