Skip to content

allow set sample name on submit.py#2998

Merged
doomedraven merged 2 commits into
masterfrom
sample_naming
Apr 28, 2026
Merged

allow set sample name on submit.py#2998
doomedraven merged 2 commits into
masterfrom
sample_naming

Conversation

@doomedraven
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a custom filename parameter for sample submissions via the CLI and GCP PubSub, while also enhancing the web UI with color-coded Priority and TLP dropdowns. Key feedback points include addressing the lack of support for the new --name argument in remote API submissions and the potential for unintended renaming during batch file uploads. Additionally, the UI color-syncing logic should be made more robust to avoid browser inconsistencies, and several PEP 8 style violations regarding line length and keyword argument spacing need to be corrected.

Comment thread utils/submit.py
Comment thread utils/submit.py
Comment thread utils/submit.py
Comment thread utils/submit.py
Comment thread web/templates/submission/index.html Outdated
@doomedraven doomedraven merged commit 5212b42 into master Apr 28, 2026
7 checks passed
@doomedraven doomedraven deleted the sample_naming branch April 28, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant