WIP

Author: chrisnojima-zoom

AGENTS.md

@@ -8,5 +8,6 @@
 - Keep types accurate. Do not use casts or misleading annotations to mask a real type mismatch just to get around an issue; fix the type or fix the implementation.
 - Do not add new exported functions, types, or constants unless they are required outside the file. Prefer file-local helpers for one-off implementation details and tests.
 - Do not use `navigation.setOptions` for header state in this repo. Pass header-driving state through route params so `getOptions` can read it synchronously, or use [`shared/stores/modal-header.tsx`](/Users/ChrisNojima/SourceCode/go/src/github.com/keybase/client/shared/stores/modal-header.tsx) when the flow already uses the shared modal header mechanism.
+- Components must not mutate Zustand stores directly with `useXState.setState`, `getState()`-based writes, or similar ad hoc store mutation. If a component needs to affect store state, route it through a store dispatch action or move the state out of the store.
 - During refactors, do not delete existing guards, conditionals, or platform/test-specific behavior unless you have proven they are dead and the user asked for that behavior change. Port checks like `androidIsTestDevice` forward into the new code path instead of silently dropping them.
 - When addressing PR or review feedback, including bot or lint-style suggestions, do not apply it mechanically. Verify that the reported issue is real in this codebase and that the proposed fix is consistent with repo rules and improves correctness, behavior, or maintainability before making changes.

shared/stores/teams.tsx

@@ -942,6 +942,7 @@ export type State = Store & {
       selected: boolean,
       clearAll?: boolean
     ) => void
+    setRespondToInviteLink: (respondToInviteLink?: (accept: boolean) => void) => void
     setNewTeamInfo: (
       deletedTeams: ReadonlyArray<T.RPCGen.DeletedTeamInfo>,
       newTeams: Set<T.Teams.TeamID>,
@@ -2287,6 +2288,11 @@ export const useTeamsState = Z.createZustand<State>('teams', (set, get) => {
         }
       })
     },
+    setRespondToInviteLink: respondToInviteLink => {
+      set(s => {
+        s.dispatch.dynamic.respondToInviteLink = respondToInviteLink
+      })
+    },
     setNewTeamInfo: (deletedTeams, newTeams, teamIDToResetUsers) => {
       set(s => {
         s.deletedTeams = T.castDraft(deletedTeams)

shared/teams/join-team/container.tsx

@@ -30,6 +30,7 @@ const Container = ({initialTeamname, success: successParam}: OwnProps) => {
   const [open, setOpen] = React.useState(false)
   const [successTeamName, setSuccessTeamName] = React.useState('')
   const [name, _setName] = React.useState(initialTeamname ?? '')
+  const setRespondToInviteLink = useTeamsState(s => s.dispatch.setRespondToInviteLink)
   const joinTeam = C.useRPC(T.RPCGen.teamsTeamAcceptInviteOrRequestAccessRpcListener)
   const navigation = useNavigation<NativeStackNavigationProp<RootParamList, 'teamJoinTeamDialog'>>()
   const navigateUp = C.Router2.navigateUp
@@ -57,28 +58,12 @@ const Container = ({initialTeamname, success: successParam}: OwnProps) => {
         {
           customResponseIncomingCallMap: {
             'keybase.1.teamsUi.confirmInviteLinkAccept': (params, response) => {
-              const currentDispatch = useTeamsState.getState().dispatch
-              useTeamsState.setState({
-                dispatch: {
-                  ...currentDispatch,
-                  dynamic: {
-                    ...currentDispatch.dynamic,
-                    respondToInviteLink: wrapErrors((accept: boolean) => {
-                      const latestDispatch = useTeamsState.getState().dispatch
-                      useTeamsState.setState({
-                        dispatch: {
-                          ...latestDispatch,
-                          dynamic: {
-                            ...latestDispatch.dynamic,
-                            respondToInviteLink: undefined,
-                          },
-                        },
-                      })
-                      response.result(accept)
-                    }),
-                  },
-                },
-              })
+              setRespondToInviteLink(
+                wrapErrors((accept: boolean) => {
+                  setRespondToInviteLink(undefined)
+                  response.result(accept)
+                })
+              )
               C.Router2.navigateAppend(
                 {
                   name: 'teamInviteLinkJoin',