Map Lean's Option to Java's Optional in getIonSerializer%#53
Merged
Merged
Conversation
The getIonSerializer% elaborator was mapping Option α to nullable T (the raw inner type), which dropped the optionality from the Java type signature. For example, IfThenElse's elseBranch field was generated as AstNode<StmtExpr> instead of java.util.Optional<AstNode<StmtExpr>>. This change: - Maps Option α to java.util.Optional<T> in type signatures - Updates serialization to use .isPresent()/.get() instead of null checks - Updates doc comment to reflect the new mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
getIonSerializer%Java code generator to map Lean'sOption αtojava.util.Optional<T>instead of nullableT.Problem
The
IfThenElserecord was generated as:The
elseBranchfield should beOptional<AstNode<StmtExpr>>since the Lean type hasOption (AstNode StmtExpr)for that field.Root Cause
In
javaTypeForInfo, the.option elemcase was mapped to justjavaBoxedTypeForInfo elem(the inner type), which completely drops the optionality from the Java type signature. The serializer correctly handled null checks, but the type system provided no safety.Fix
.option elemnow maps tojava.util.Optional<{boxedType}>instead of just the raw inner type.isPresent()/.get()instead of null checksNoneas IonnullAfter
Testing
lake build Strata.DDM.Integration.Java.Gen✓lake build StrataTest✓ (583 jobs)Addresses strata-org/jverify#405 comment."
true