move license validation codes into poro model

Author: ezekg

app/models/analytics/gauge/validations.rb

@@ -9,7 +9,7 @@ def initialize(account:, environment:, license_id: nil)
         @license_id  = license_id
       end
 
-      def metrics = Analytics::Series::Sparks::Validations::METRICS
+      def metrics = LicenseValidation::CODES.map { "validations.#{it.underscore.dasherize}" }
       def count
         event_type_ids = EventType.by_pattern('license.validation.*')
                                   .collect(&:id)

app/models/analytics/series/sparks/validations.rb

@@ -4,56 +4,14 @@ module Analytics
   class Series
     class Sparks
       class Validations
-        METRICS = %w[
-          validations.banned
-          validations.checksum-scope-mismatch
-          validations.checksum-scope-required
-          validations.components-scope-empty
-          validations.components-scope-mismatch
-          validations.components-scope-required
-          validations.entitlements-missing
-          validations.entitlements-scope-empty
-          validations.environment-scope-mismatch
-          validations.environment-scope-required
-          validations.expired
-          validations.fingerprint-scope-empty
-          validations.fingerprint-scope-mismatch
-          validations.fingerprint-scope-required
-          validations.heartbeat-dead
-          validations.heartbeat-not-started
-          validations.machine-scope-mismatch
-          validations.machine-scope-required
-          validations.no-machine
-          validations.no-machines
-          validations.not-found
-          validations.overdue
-          validations.policy-scope-mismatch
-          validations.policy-scope-required
-          validations.product-scope-mismatch
-          validations.product-scope-required
-          validations.suspended
-          validations.too-many-cores
-          validations.too-many-machines
-          validations.too-many-processes
-          validations.too-many-users
-          validations.too-much-disk
-          validations.too-much-memory
-          validations.user-scope-mismatch
-          validations.user-scope-required
-          validations.valid
-          validations.version-scope-mismatch
-          validations.version-scope-required
-        ].freeze
-
         def initialize(account:, environment:, license_id: nil, realtime: true, **)
           @account     = account
           @environment = environment
           @license_id  = license_id
           @realtime    = realtime
         end
 
-        def metrics = METRICS
-
+        def metrics = LicenseValidation::CODES.map { "validations.#{it.underscore.dasherize}" }
         def count(start_date:, end_date:)
           scope = LicenseValidationSpark.for_account(account)
                                         .for_environment(environment)

app/models/license_validation.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+# TODO(ezekg) eventually refactor validation service into models
+class LicenseValidation
+  CODES = %w[
+    BANNED
+    CHECKSUM_SCOPE_MISMATCH
+    CHECKSUM_SCOPE_REQUIRED
+    COMPONENTS_SCOPE_EMPTY
+    COMPONENTS_SCOPE_MISMATCH
+    COMPONENTS_SCOPE_REQUIRED
+    ENTITLEMENTS_MISSING
+    ENTITLEMENTS_SCOPE_EMPTY
+    ENVIRONMENT_SCOPE_MISMATCH
+    ENVIRONMENT_SCOPE_REQUIRED
+    EXPIRED
+    FINGERPRINT_SCOPE_EMPTY
+    FINGERPRINT_SCOPE_MISMATCH
+    FINGERPRINT_SCOPE_REQUIRED
+    HEARTBEAT_DEAD
+    HEARTBEAT_NOT_STARTED
+    MACHINE_SCOPE_MISMATCH
+    MACHINE_SCOPE_REQUIRED
+    NO_MACHINE
+    NO_MACHINES
+    NOT_FOUND
+    OVERDUE
+    POLICY_SCOPE_MISMATCH
+    POLICY_SCOPE_REQUIRED
+    PRODUCT_SCOPE_MISMATCH
+    PRODUCT_SCOPE_REQUIRED
+    SUSPENDED
+    TOO_MANY_CORES
+    TOO_MANY_MACHINES
+    TOO_MANY_PROCESSES
+    TOO_MANY_USERS
+    TOO_MUCH_DISK
+    TOO_MUCH_MEMORY
+    USER_SCOPE_MISMATCH
+    USER_SCOPE_REQUIRED
+    VALID
+    VERSION_SCOPE_MISMATCH
+    VERSION_SCOPE_REQUIRED
+  ].freeze
+end