Draft
Conversation
ezekg
force-pushed
the
feature/add-origin-to-request-logs
branch
9 times, most recently
from
71dd988 to
3501303
Compare
ezekg
force-pushed
the
feature/add-origin-to-request-logs
branch
from
3501303 to
423b8e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors how we count and log requests, rather than simply relying on the spoofable
Originheader. This will also greatly aid debuggability on our end, as we'll now be able to review full request logs from Portal. In the future, we can add more sophisticated proof-of-browser fingerprinting and if needed static IP addresses for Portal to prevent abuse.Prereqs