Skip to content

Commit d583f3a

Browse files
Apply suggestions from code review
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
1 parent ff914aa commit d583f3a

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

script/statistics/annual-statistics.inc.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77

88
namespace Keyman\Site\com\keyman\api;
99

10-
// strip out repeated columns with numeric keys
10+
// strip out repeated columns with numeric keys (by default the results returned
11+
// give each column twice, once with a column name, and once with a column index)
1112
function filter_columns_by_name($data) {
1213
$result = [];
1314
foreach($data as $row) {

tools/db/build/annual-statistics.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ CREATE PROCEDURE sp_keyboard_downloads_by_month_statistics (
5252
month(statdate) Month,
5353
year(statdate) Year,
5454
sum(count) RawKeyboardDownloadCount,
55-
sum(count)/day(eomonth(datefromparts(year(statdate),month(statdate),1))) DownloadsPerDay
55+
sum(count)/day(eomonth(datefromparts(year(statdate),month(statdate),1))) DownloadsPerDay
5656
from kstats.t_keyboard_downloads
5757
WHERE statdate >= @prmStartDate AND statdate < @prmEndDate
5858
group by month(statdate), year(statdate)

0 commit comments

Comments
 (0)