[shanghai_telex] updating #4040
Merged
Merged
Conversation
Collaborator
|
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
Contributor
|
You might consider making the same changes to the help file as you did the vietnamese one. It doesn't have the table dividers or the key field: https://help.keyman.com/keyboard/shanghai_telex/1.0/shanghai_telex You've added about 300 rules. Please be careful not to let the keyboard grow too much more as it takes awhile to compile. |
Contributor
Author
|
I have already made the same change on this keyboard
Sent with [Proton Mail](https://proton.me/mail/home) secure email.
…On Thursday, 25 June 2026 at 3:57 PM, Lorna Evans ***@***.***> wrote:
LornaSIL left a comment [(keymanapp/keyboards#4040)](#4040 (comment))
You might consider making the same changes to the help file as you did the vietnamese one. It doesn't have the table dividers or the key field: https://help.keyman.com/keyboard/shanghai_telex/1.0/shanghai_telex
You've added about 300 rules. Please be careful not to let the keyboard grow too much more as it takes awhile to compile.
—
Reply to this email directly, [view it on GitHub](#4040?email_source=notifications&email_token=BCAJHRUYIYFGB4VBJYL3KML5BU4XLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBQGA3TKNJWHE42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4800755699), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BCAJHRU55XOR3REORGX5XFT5BU4XLAVCNFSNUABEKJSXA33TNF2G64TZHMYTCNBZGU4TONJ3JFZXG5LFHM2DOMZXHE4DEOJQGCQXMAQ).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
Author
|
I changed the table. Please check
Sent with [Proton Mail](https://proton.me/mail/home) secure email.
…On Thursday, 25 June 2026 at 3:57 PM, Lorna Evans ***@***.***> wrote:
LornaSIL left a comment [(keymanapp/keyboards#4040)](#4040 (comment))
You might consider making the same changes to the help file as you did the vietnamese one. It doesn't have the table dividers or the key field: https://help.keyman.com/keyboard/shanghai_telex/1.0/shanghai_telex
You've added about 300 rules. Please be careful not to let the keyboard grow too much more as it takes awhile to compile.
—
Reply to this email directly, [view it on GitHub](#4040?email_source=notifications&email_token=BCAJHRUYIYFGB4VBJYL3KML5BU4XLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBQGA3TKNJWHE42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4800755699), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BCAJHRU55XOR3REORGX5XFT5BU4XLAVCNFSNUABEKJSXA33TNF2G64TZHMYTCNBZGU4TONJ3JFZXG5LFHM2DOMZXHE4DEOJQGCQXMAQ).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ready for reviewing