Skip to content

test(web): add e2e tests for examples from guide#16108

Merged
ermshiperete merged 2 commits into
masterfrom
test/web/guide-examples
Jun 29, 2026
Merged

test(web): add e2e tests for examples from guide#16108
ermshiperete merged 2 commits into
masterfrom
test/web/guide-examples

Conversation

@ermshiperete

Copy link
Copy Markdown
Contributor

Build-bot: skip build:web
Test-bot: skip

@keymanapp-test-bot

keymanapp-test-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Web
    • KeymanWeb Test Home - build : all tests passed (no artifacts on BuildLevel "build")

@keymanapp-test-bot keymanapp-test-bot Bot added this to the A19S31 milestone Jun 18, 2026
@github-actions github-actions Bot added web/ test Any acceptance test issue labels Jun 18, 2026
@ermshiperete ermshiperete force-pushed the test/web/guide-examples branch from 702a641 to 6f10d3c Compare June 18, 2026 17:29
Build-bot: skip build:web
Test-bot: skip
@ermshiperete ermshiperete force-pushed the test/web/guide-examples branch from 6f10d3c to bda4b50 Compare June 18, 2026 17:43

@mcdurdin mcdurdin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far

@keyman-server keyman-server modified the milestones: A19S31, A19S32 Jun 22, 2026
@ermshiperete ermshiperete marked this pull request as ready for review June 22, 2026 07:42
@ermshiperete ermshiperete requested a review from mcdurdin June 25, 2026 09:12

@mcdurdin mcdurdin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far

Comment thread web/build.sh
Comment on lines +128 to +129
sed "s|https://s\.keyman\.com/kmw/engine/[0-9]*\.[0-9]*\.[0-9]*/|/build/publish/${config}/|g" \
"${f}" > "${f}.tmp" && mv "${f}.tmp" "${f}"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment on this? It's a little bit obscure

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ermshiperete ermshiperete enabled auto-merge June 29, 2026 15:10
@ermshiperete ermshiperete merged commit a2150b1 into master Jun 29, 2026
8 checks passed
@ermshiperete ermshiperete deleted the test/web/guide-examples branch June 29, 2026 15:30
@github-project-automation github-project-automation Bot moved this from Todo to Done in Keyman Jun 29, 2026
@keyman-server

Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.248-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Any acceptance test issue web/

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants