Skip to content

feat: add .pkg support for mac links #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgschantz merged 1 commit into from
Jun 18, 2026
Merged

feat: add .pkg support for mac links #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions public/src/app/pull-request/pull-request.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,6 @@ export class PullRequestComponent extends PopupComponent implements OnInit, OnCh
'KeymanAndroid_TestPullRequests': {platform: 'android', name: 'Android', icon: 'android.png', downloads: [
{fragment: 'release/keyman-$version.apk', name: 'Keyman for Android apk', icon: 'keyman.png'} ,
{fragment: 'release/FirstVoices/firstvoices-$version.apk', name: 'FirstVoices Keyboards for Android apk', icon: 'firstvoices.png'} ,

// TODO: Remove 16.0 links when 17.0 released
{fragment: 'release/kMAPro-debug.apk', name: 'Keyman for Android 16.0 apk', icon: 'keyman.png'} ,
{fragment: 'release/FirstVoices/app-debug.apk', name: 'FirstVoices for Android 16.0 apk', icon: 'firstvoices.png'} ,
]},
'KeymanAndroid_TestSamplesAndTestProjects': {platform: 'android', name: 'Android', icon: 'android.png', downloads: [
{fragment: 'Samples/KMSample1/app-debug.apk', name: 'KMSample1 apk', icon: 'kmsample1.png'} ,
Expand All @@ -183,7 +179,8 @@ export class PullRequestComponent extends PopupComponent implements OnInit, OnCh
]},

'Keyman_KeymanMac_PullRequests': {platform: 'mac', name: 'macOS', icon: 'mac.png', downloads: [
{fragment: 'upload/$version/keyman-$version.dmg', name: 'Keyman for macOS', icon: 'keyman.png'} ,
{fragment: 'upload/$version/keyman-$version.pkg', name: 'Keyman for macOS (.pkg)', icon: 'keyman.png'} ,
{fragment: 'upload/$version/keyman-$version.dmg', name: 'Keyman for macOS (.dmg)', icon: 'keyman.png'} ,
]},

'KeymanDesktop_TestPullRequests': {platform: 'windows', name: 'Windows', icon: 'windows.png', downloads: [
Expand Down
3 changes: 2 additions & 1 deletion shared/artifact-links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ export const artifactLinks = {
]},

'Keyman_KeymanMac_PullRequests': {platform: 'mac', name: 'macOS', icon: 'mac.png', downloads: [
{fragment: 'upload/$version/keyman-$version_with_tag.dmg', name: '**Keyman for macOS**', icon: 'keyman.png'} ,
{fragment: 'upload/$version/keyman-$version_with_tag.dmg', name: '**Keyman for macOS (.dmg)**', icon: 'keyman.png'} ,
{fragment: 'upload/$version/keyman-$version_with_tag.pkg', name: '**Keyman for macOS (.pkg)**', icon: 'keyman.png'} ,
//TODO: remove next download when version_with_tag artifact filenames have propagated everywhere
{fragment: 'upload/$version/keyman-$version.dmg', name: 'Keyman for macOS (old PRs)', icon: 'keyman.png'} ,
]},
Expand Down
Loading