#1625 fix some bugs with http request action

Author: sds100

app/src/main/AndroidManifest.xml

@@ -77,13 +77,15 @@
     <application
         android:name="io.github.sds100.keymapper.KeyMapperApp"
         android:allowBackup="true"
+        android:directBootAware="true"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
-        android:directBootAware="true"
         android:roundIcon="@mipmap/ic_launcher_round"
         android:supportsRtl="true"
         android:theme="@style/AppTheme.NoActionBar"
+        android:usesCleartextTraffic="true"
         tools:ignore="GoogleAppIndexingWarning">
+        <!--  Allow clear text traffic due to the HTTP Request Action. -->
 
         <activity
             android:name=".MainActivity"

app/src/main/java/io/github/sds100/keymapper/actions/ActionData.kt

@@ -839,5 +839,10 @@ sealed class ActionData : Comparable<ActionData> {
         val authorizationHeader: String,
     ) : ActionData() {
         override val id: ActionId = ActionId.HTTP_REQUEST
+
+        override fun toString(): String {
+            // Do not leak sensitive request info to logs.
+            return "HttpRequest(description=$description)"
+        }
     }
 }

app/src/main/java/io/github/sds100/keymapper/actions/HttpRequestBottomSheet.kt

@@ -73,6 +73,10 @@ fun HttpRequestBottomSheet(delegate: CreateActionDelegate) {
                 delegate.httpRequestBottomSheetState =
                     delegate.httpRequestBottomSheetState?.copy(body = it)
             },
+            onAuthorizationChanged = {
+                delegate.httpRequestBottomSheetState =
+                    delegate.httpRequestBottomSheetState?.copy(authorizationHeader = it)
+            },
             onDoneClick = {
                 val result = delegate.httpRequestBottomSheetState ?: return@HttpRequestBottomSheet
                 delegate.httpRequestBottomSheetState = null
@@ -92,6 +96,7 @@ private fun HttpRequestBottomSheet(
     onDescriptionChanged: (String) -> Unit = {},
     onUrlChanged: (String) -> Unit = {},
     onBodyChanged: (String) -> Unit = {},
+    onAuthorizationChanged: (String) -> Unit = {},
     onDoneClick: () -> Unit = {},
 ) {
     val scrollState = rememberScrollState()
@@ -221,11 +226,16 @@ private fun HttpRequestBottomSheet(
                 value = state.authorizationHeader,
                 label = { Text(stringResource(R.string.action_http_request_authorization_label)) },
                 onValueChange = {
-                    onBodyChanged(it)
+                    onAuthorizationChanged(it)
                 },
                 supportingText = {
                     Text(stringResource(R.string.action_http_request_authorization_supporting_text))
                 },
+                keyboardOptions = KeyboardOptions(
+                    capitalization = KeyboardCapitalization.None,
+                    autoCorrectEnabled = false,
+                    keyboardType = KeyboardType.Text,
+                ),
             )
 
             Spacer(modifier = Modifier.height(16.dp))

app/src/main/java/io/github/sds100/keymapper/system/network/AndroidNetworkAdapter.kt

@@ -152,20 +152,23 @@ class AndroidNetworkAdapter(
             }
 
             val request = requestBody
-                .url("https://posttestserver.dev/p/kmr33yjcz5h38hkq/post")
+                .url(url)
                 .headers(headers.build())
                 .build()
 
             withContext(Dispatchers.IO) { httpClient.newCall(request).execute() }
                 .use { response ->
-                    Timber.e(response.toString())
+                    // Keep this in. It is useful for debugging.
+                    Timber.d(response.toString())
+
                     if (!response.isSuccessful) {
                         return Error.UnknownIOError
                     }
 
                     return Success(Unit)
                 }
         } catch (e: IOException) {
+            Timber.e(e)
             return Error.UnknownIOError
         }
     }