#1635 fix: do not crash if the URL for the HTTP action is malformed

Author: sds100

CHANGELOG.md

@@ -1,11 +1,17 @@
+## [3.0 Beta 6](https://github.com/sds100/KeyMapper/releases/tag/v3.0.0-beta.6)
+
+#### TO BE RELEASED
+
+## Bug fixes
+
+- #1635 do not crash if the URL for the HTTP action is malformed
+
 ## [3.0 Beta 5](https://github.com/sds100/KeyMapper/releases/tag/v3.0.0-beta.5)
 
 #### 6 April 2025
 
 - #1625 HTTP Request action.
 
-###
-
 ## Bug fixes
 
 - #1627 open camera app action does not work when device is locked

app/src/main/java/io/github/sds100/keymapper/actions/CreateActionDelegate.kt

@@ -777,7 +777,7 @@ class CreateActionDelegate(
                     httpRequestBottomSheetState = ActionData.HttpRequest(
                         description = "",
                         method = HttpMethod.GET,
-                        url = "",
+                        url = "http://",
                         body = "",
                         authorizationHeader = "",
                     )

app/src/main/java/io/github/sds100/keymapper/actions/HttpRequestBottomSheet.kt

@@ -43,6 +43,7 @@ import io.github.sds100.keymapper.system.network.HttpMethod
 import io.github.sds100.keymapper.util.ui.compose.KeyMapperDropdownMenu
 import kotlinx.coroutines.flow.update
 import kotlinx.coroutines.launch
+import okhttp3.HttpUrl.Companion.toHttpUrlOrNull
 
 @OptIn(ExperimentalMaterial3Api::class)
 @Composable
@@ -106,6 +107,7 @@ private fun HttpRequestBottomSheet(
     val descriptionEmptyErrorString =
         stringResource(R.string.action_http_request_description_empty_error)
     val urlEmptyErrorString = stringResource(R.string.action_http_request_url_empty_error)
+    val malformedUrlErrorString = stringResource(R.string.action_http_request_malformed_url_error)
 
     var descriptionError: String? by rememberSaveable { mutableStateOf(null) }
     var urlError: String? by rememberSaveable { mutableStateOf(null) }
@@ -272,6 +274,10 @@ private fun HttpRequestBottomSheet(
                             urlError = urlEmptyErrorString
                         }
 
+                        if (state.url.toHttpUrlOrNull() == null) {
+                            urlError = malformedUrlErrorString
+                        }
+
                         if (descriptionError == null && urlError == null) {
                             onDoneClick()
                         }

app/src/main/java/io/github/sds100/keymapper/system/network/AndroidNetworkAdapter.kt

@@ -170,6 +170,8 @@ class AndroidNetworkAdapter(
         } catch (e: IOException) {
             Timber.e(e)
             return Error.UnknownIOError
+        } catch (e: IllegalArgumentException) {
+            return Error.MalformedUrl
         }
     }
 }

app/src/main/java/io/github/sds100/keymapper/util/ErrorUtils.kt

@@ -161,6 +161,7 @@ fun Error.getFullMessage(resourceProvider: ResourceProvider): String = when (thi
     Error.PurchasingNotImplemented -> resourceProvider.getString(R.string.purchasing_error_not_implemented)
     Error.DpadTriggerImeNotSelected -> resourceProvider.getString(R.string.trigger_error_dpad_ime_not_selected)
     Error.InvalidBackup -> resourceProvider.getString(R.string.error_invalid_backup)
+    Error.MalformedUrl -> resourceProvider.getString(R.string.error_malformed_url)
 }
 
 val Error.isFixable: Boolean

app/src/main/java/io/github/sds100/keymapper/util/Result.kt

@@ -144,6 +144,7 @@ sealed class Error : Result<Nothing>() {
      * DPAD triggers require a Key Mapper keyboard to be selected.
      */
     data object DpadTriggerImeNotSelected : Error()
+    data object MalformedUrl : Error()
 }
 
 inline fun <T> Result<T>.onSuccess(f: (T) -> Unit): Result<T> {

app/src/main/res/values/strings.xml

@@ -885,6 +885,7 @@
     <string name="error_no_file_name">This file has no name!</string>
     <string name="error_invalid_backup">Invalid file. Must be a zip exported from Key Mapper.</string>
     <string name="error_choose_bluetooth_devices_permission_denied">You must grant Key Mapper permission to see your paired Bluetooth devices.</string>
+    <string name="error_malformed_url">Malformed URL. Did you forget the http://?</string>
 
     <string name="error_access_fine_location_permission_denied">Denied permission to read fine location!</string>
     <string name="error_answer_end_phone_call_permission_denied">Denied permission to answer and end phone calls!</string>
@@ -1083,6 +1084,7 @@
     <string name="action_http_request_description_empty_error">Can not be empty!</string>
     <string name="action_http_request_url_label">URL</string>
     <string name="action_http_request_url_empty_error">Can not be empty!</string>
+    <string name="action_http_request_malformed_url_error">Malformed URL. Did you forget the http://?</string>
     <string name="action_http_request_body_label">Request body (optional)</string>
     <string name="action_http_request_authorization_label">Authorization header (optional)</string>
     <string name="action_http_request_authorization_supporting_text">You must prepend \'Bearer\' if necessary</string>