#1637 feat: show a home screen error if notification permission is not granted

Author: sds100

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 #### TO BE RELEASED
 
+## Added
+
+- #1637 show a home screen error if notification permission is not granted.
+
 ## Bug fixes
 
 - Do not automatically select the key mapper keyboard when the accessibility service starts.

app/src/main/java/io/github/sds100/keymapper/home/ShowHomeScreenAlertsUseCase.kt

@@ -52,6 +52,13 @@ class ShowHomeScreenAlertsUseCaseImpl(
     override fun disableLogging() {
         preferences.set(Keys.log, false)
     }
+
+    override val isNotificationPermissionGranted: Flow<Boolean> =
+        permissions.isGrantedFlow(Permission.POST_NOTIFICATIONS)
+
+    override fun requestNotificationPermission() {
+        permissions.request(Permission.POST_NOTIFICATIONS)
+    }
 }
 
 interface ShowHomeScreenAlertsUseCase {
@@ -68,4 +75,7 @@ interface ShowHomeScreenAlertsUseCase {
 
     val isLoggingEnabled: Flow<Boolean>
     fun disableLogging()
+
+    val isNotificationPermissionGranted: Flow<Boolean>
+    fun requestNotificationPermission()
 }

app/src/main/java/io/github/sds100/keymapper/mappings/keymaps/KeyMapListViewModel.kt

@@ -94,6 +94,7 @@ class KeyMapListViewModel(
         const val ID_ACCESSIBILITY_SERVICE_CRASHED_LIST_ITEM = "accessibility_service_crashed"
         const val ID_BATTERY_OPTIMISATION_LIST_ITEM = "battery_optimised"
         const val ID_LOGGING_ENABLED_LIST_ITEM = "logging_enabled"
+        const val ID_NOTIFICATION_PERMISSION_DENIED_LIST_ITEM = "notification_permission_denied"
     }
 
     val sortViewModel = SortViewModel(coroutineScope, sortKeyMaps)
@@ -152,7 +153,8 @@ class KeyMapListViewModel(
         showAlertsUseCase.accessibilityServiceState,
         showAlertsUseCase.hideAlerts,
         showAlertsUseCase.isLoggingEnabled,
-    ) { isBatteryOptimised, serviceState, isHidden, isLoggingEnabled ->
+        showAlertsUseCase.isNotificationPermissionGranted,
+    ) { isBatteryOptimised, serviceState, isHidden, isLoggingEnabled, isNotificationPermissionGranted ->
         if (isHidden) {
             return@combine emptyList()
         }
@@ -187,6 +189,15 @@ class KeyMapListViewModel(
                 )
             } // don't show a success message for this
 
+            if (!isNotificationPermissionGranted) {
+                add(
+                    HomeWarningListItem(
+                        ID_NOTIFICATION_PERMISSION_DENIED_LIST_ITEM,
+                        getString(R.string.home_error_notification_permission),
+                    ),
+                )
+            }
+
             if (isLoggingEnabled) {
                 add(
                     HomeWarningListItem(
@@ -672,6 +683,7 @@ class KeyMapListViewModel(
 
                 ID_BATTERY_OPTIMISATION_LIST_ITEM -> showAlertsUseCase.disableBatteryOptimisation()
                 ID_LOGGING_ENABLED_LIST_ITEM -> showAlertsUseCase.disableLogging()
+                ID_NOTIFICATION_PERMISSION_DENIED_LIST_ITEM -> showAlertsUseCase.requestNotificationPermission()
             }
         }
     }

app/src/main/res/values/strings.xml

@@ -90,6 +90,7 @@
     <string name="home_success_accessibility_service_is_enabled">The accessibility service is enabled! Your key maps should work.</string>
     <string name="home_error_logging_enabled">Extra logging is turned on! Turn this off if you aren\'t trying to fix an issue.</string>
     <string name="home_error_logging_enabled_button">Turn off</string>
+    <string name="home_error_notification_permission">Turn on notifications for better on-screen messages, more actions and service updates.</string>
 
     <string name="title_about">About</string>
     <!--  Action descriptions  -->