Skip to content

Commit 8d0b388

Browse files
committed
#1593 Deprecate open menu action
Closes #1593
1 parent 9b76ed4 commit 8d0b388

File tree

3 files changed

+11
-0
lines changed

3 files changed

+11
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ _See the changes from previous 3.0 Beta releases as well._
1212
## Changed
1313

1414
- #1577 Move unsupported actions to the bottom of the list and do not allow selecting root actions if root permission is not granted.
15+
- #1593 Deprecate the 'Open menu' action by not letting new key maps use it. It is a relic of the past when most apps had a 3-dot menu with a consistent content description making it somewhat easy to identify.
1516

1617
## Bug fixes
1718

app/src/main/java/io/github/sds100/keymapper/actions/ChooseActionViewModel.kt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,14 @@ class ChooseActionViewModel(
126126
actionIds: List<ActionId>,
127127
): List<SimpleListItemModel> = buildList {
128128
for (actionId in actionIds) {
129+
// See Issue #1593. This action should no longer exist because it is a relic
130+
// of the past when most apps had a 3-dot menu with a consistent content description
131+
// making it somewhat easy to identify. This action should still be usable
132+
// if a user already has a key map with it so just hide it from the list.
133+
if (actionId == ActionId.OPEN_MENU) {
134+
continue
135+
}
136+
129137
val error = useCase.isSupported(actionId)
130138
val isSupported = error == null
131139

docs/user-guide/actions.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,8 @@ This will increase or decrease a specific one of these volume streams.
169169

170170
### Open menu
171171

172+
!!! attention "Deprecated in Key Mapper 3.0+"
173+
172174
### Toggle/enable/disable flashlight
173175

174176
In Key Mapper 3.0+ there is the option to also set a custom brightness. This is only supported on Android 13+ and on some devices.

0 commit comments

Comments
 (0)