Merge remote-tracking branch 'origin/develop' into develop

Author: sds100

CHANGELOG.md

@@ -8,6 +8,7 @@
 
 ## Fixed
 
+- #2154 The expert mode debug screen is now only accessible after the expert mode warning has been acknowledged.
 - #2074 Scrolling the action or trigger list no longer accidentally moves items; reordering by drag now only activates from the drag handle or via long-press.
 
 ## Changed

base/src/main/java/io/github/sds100/keymapper/base/expertmode/ExpertModeScreen.kt

@@ -252,34 +252,34 @@ private fun Content(
                     )
                 }
             }
+
+            Spacer(modifier = Modifier.height(16.dp))
+
+            OptionsHeaderRow(
+                modifier = Modifier
+                    .fillMaxWidth()
+                    .padding(horizontal = 16.dp),
+                icon = Icons.Outlined.BugReport,
+                text = stringResource(R.string.settings_section_debugging_title),
+            )
+
+            Spacer(modifier = Modifier.height(8.dp))
+
+            OptionPageButton(
+                modifier = Modifier.padding(horizontal = 8.dp),
+                title = stringResource(R.string.title_pref_get_event_debug),
+                text = stringResource(R.string.summary_pref_get_event_debug),
+                icon = Icons.Outlined.BugReport,
+                onClick = onGetEventClick,
+            )
+            Spacer(modifier = Modifier.height(8.dp))
         } else {
             Text(
                 modifier = Modifier.padding(horizontal = 32.dp),
                 text = stringResource(R.string.expert_mode_settings_unavailable_text),
                 textAlign = TextAlign.Center,
             )
         }
-
-        Spacer(modifier = Modifier.height(16.dp))
-
-        OptionsHeaderRow(
-            modifier = Modifier
-                .fillMaxWidth()
-                .padding(horizontal = 16.dp),
-            icon = Icons.Outlined.BugReport,
-            text = stringResource(R.string.settings_section_debugging_title),
-        )
-
-        Spacer(modifier = Modifier.height(8.dp))
-
-        OptionPageButton(
-            modifier = Modifier.padding(horizontal = 8.dp),
-            title = stringResource(R.string.title_pref_get_event_debug),
-            text = stringResource(R.string.summary_pref_get_event_debug),
-            icon = Icons.Outlined.BugReport,
-            onClick = onGetEventClick,
-        )
-        Spacer(modifier = Modifier.height(8.dp))
     }
 }
 

base/src/main/java/io/github/sds100/keymapper/base/expertmode/ExpertModeViewModel.kt

@@ -190,6 +190,7 @@ class ExpertModeViewModel @Inject constructor(
 
     fun onGetEventClick() {
         viewModelScope.launch {
+            if (warningState.value !is ExpertModeWarningState.Understood) return@launch
             navigate("get_event_debug", NavDestination.GetEvent)
         }
     }