fix: check that a URL can be opened and show a toast if not

Author: sds100

app/src/main/java/io/github/sds100/keymapper/actions/ActionOptionsBottomSheet.kt

@@ -30,6 +30,7 @@ import androidx.compose.runtime.Composable
 import androidx.compose.runtime.rememberCoroutineScope
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.platform.LocalDensity
 import androidx.compose.ui.platform.LocalUriHandler
 import androidx.compose.ui.res.stringResource
@@ -44,6 +45,7 @@ import io.github.sds100.keymapper.util.ui.SliderStepSizes
 import io.github.sds100.keymapper.util.ui.compose.CheckBoxText
 import io.github.sds100.keymapper.util.ui.compose.RadioButtonText
 import io.github.sds100.keymapper.util.ui.compose.SliderOptionText
+import io.github.sds100.keymapper.util.ui.compose.openUriSafe
 import kotlinx.coroutines.launch
 
 @OptIn(ExperimentalMaterial3Api::class)
@@ -63,6 +65,7 @@ fun ActionOptionsBottomSheet(
         dragHandle = {},
     ) {
         val uriHandler = LocalUriHandler.current
+        val ctx = LocalContext.current
         val helpUrl = stringResource(R.string.url_keymap_action_options_guide)
         val scope = rememberCoroutineScope()
 
@@ -80,7 +83,7 @@ fun ActionOptionsBottomSheet(
                     modifier = Modifier
                         .align(Alignment.TopEnd)
                         .padding(horizontal = 8.dp),
-                    onClick = { uriHandler.openUri(helpUrl) },
+                    onClick = { uriHandler.openUriSafe(ctx, helpUrl) },
                 ) {
                     Icon(
                         imageVector = Icons.AutoMirrored.Rounded.HelpOutline,

app/src/main/java/io/github/sds100/keymapper/home/HomeKeyMapListScreen.kt

@@ -68,6 +68,7 @@ import io.github.sds100.keymapper.util.drawable
 import io.github.sds100.keymapper.util.ui.compose.CollapsableFloatingActionButton
 import io.github.sds100.keymapper.util.ui.compose.ComposeChipModel
 import io.github.sds100.keymapper.util.ui.compose.ComposeIconInfo
+import io.github.sds100.keymapper.util.ui.compose.openUriSafe
 
 @OptIn(ExperimentalMaterial3Api::class)
 @Composable
@@ -140,6 +141,7 @@ fun HomeKeyMapListScreen(
 
     val scrollBehavior = TopAppBarDefaults.pinnedScrollBehavior()
     val uriHandler = LocalUriHandler.current
+    val ctx = LocalContext.current
     val helpUrl = stringResource(R.string.url_quick_start_guide)
 
     var keyMapListBottomPadding by remember { mutableStateOf(100.dp) }
@@ -183,7 +185,7 @@ fun HomeKeyMapListScreen(
                 onSettingsClick = onSettingsClick,
                 onAboutClick = onAboutClick,
                 onSortClick = { viewModel.showSortBottomSheet = true },
-                onHelpClick = { uriHandler.openUri(helpUrl) },
+                onHelpClick = { uriHandler.openUriSafe(ctx, helpUrl) },
                 onExportClick = viewModel::onExportClick,
                 onImportClick = { importFileLauncher.launch(FileUtils.MIME_TYPE_ALL) },
                 onTogglePausedClick = viewModel::onTogglePausedClick,

app/src/main/java/io/github/sds100/keymapper/mappings/keymaps/ConfigKeyMapScreen.kt

@@ -46,6 +46,7 @@ import androidx.compose.runtime.saveable.rememberSaveable
 import androidx.compose.runtime.setValue
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.platform.LocalUriHandler
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.tooling.preview.Devices
@@ -58,6 +59,7 @@ import io.github.sds100.keymapper.actions.ActionsScreen
 import io.github.sds100.keymapper.compose.KeyMapperTheme
 import io.github.sds100.keymapper.constraints.ConstraintsScreen
 import io.github.sds100.keymapper.mappings.keymaps.trigger.TriggerScreen
+import io.github.sds100.keymapper.util.ui.compose.openUriSafe
 import kotlinx.coroutines.launch
 
 @Composable
@@ -141,6 +143,7 @@ private fun ConfigKeyMapScreen(
 
     var currentTab: ConfigKeyMapTab? by remember { mutableStateOf(null) }
     val uriHandler = LocalUriHandler.current
+    val ctx = LocalContext.current
 
     BackHandler(onBack = onBackClick)
 
@@ -167,7 +170,7 @@ private fun ConfigKeyMapScreen(
                     }
 
                     if (url.isNotEmpty()) {
-                        uriHandler.openUri(url)
+                        uriHandler.openUriSafe(ctx, url)
                     }
                 },
             )
@@ -505,6 +508,7 @@ private fun ScreenCard(
     screen: @Composable () -> Unit,
 ) {
     val uriHandler = LocalUriHandler.current
+    val ctx = LocalContext.current
 
     OutlinedCard(modifier = modifier) {
         Column {
@@ -520,7 +524,7 @@ private fun ScreenCard(
                     color = MaterialTheme.colorScheme.primary,
                 )
 
-                IconButton(onClick = { uriHandler.openUri(helpUrl) }) {
+                IconButton(onClick = { uriHandler.openUriSafe(ctx, helpUrl) }) {
                     Icon(
                         Icons.AutoMirrored.Rounded.HelpOutline,
                         contentDescription = stringResource(R.string.button_help),

app/src/main/java/io/github/sds100/keymapper/mappings/keymaps/KeyMapOptionsScreen.kt

@@ -34,6 +34,7 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.platform.ClipEntry
 import androidx.compose.ui.platform.LocalClipboard
+import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.platform.LocalUriHandler
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.style.TextOverflow
@@ -48,6 +49,7 @@ import io.github.sds100.keymapper.util.ui.SliderMinimums
 import io.github.sds100.keymapper.util.ui.SliderStepSizes
 import io.github.sds100.keymapper.util.ui.compose.CheckBoxText
 import io.github.sds100.keymapper.util.ui.compose.SliderOptionText
+import io.github.sds100.keymapper.util.ui.compose.openUriSafe
 import kotlinx.coroutines.launch
 
 @Composable
@@ -323,14 +325,15 @@ private fun TriggerFromOtherAppsSection(
                 }
 
                 val uriHandler = LocalUriHandler.current
+                val ctx = LocalContext.current
                 val intentGuideUrl = stringResource(R.string.url_trigger_by_intent_guide)
 
                 FilledTonalButton(
                     modifier = Modifier
                         .fillMaxWidth()
                         .padding(horizontal = 16.dp),
                     onClick = {
-                        uriHandler.openUri(intentGuideUrl)
+                        uriHandler.openUriSafe(ctx, intentGuideUrl)
                     },
                 ) {
                     Text(text = stringResource(R.string.button_open_trigger_keymap_from_intent_guide))

app/src/main/java/io/github/sds100/keymapper/mappings/keymaps/trigger/SetupGuiKeyboardBottomSheet.kt

@@ -24,6 +24,7 @@ import androidx.compose.runtime.getValue
 import androidx.compose.runtime.rememberCoroutineScope
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.platform.LocalDensity
 import androidx.compose.ui.platform.LocalUriHandler
 import androidx.compose.ui.res.stringResource
@@ -34,6 +35,7 @@ import androidx.compose.ui.unit.dp
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
 import io.github.sds100.keymapper.R
 import io.github.sds100.keymapper.compose.KeyMapperTheme
+import io.github.sds100.keymapper.util.ui.compose.openUriSafe
 import kotlinx.coroutines.launch
 
 @OptIn(ExperimentalMaterial3Api::class)
@@ -101,6 +103,7 @@ private fun SetupGuiKeyboardBottomSheet(
 ) {
     val scope = rememberCoroutineScope()
     val uriHandler = LocalUriHandler.current
+    val ctx = LocalContext.current
     val scrollState = rememberScrollState()
 
     ModalBottomSheet(
@@ -145,7 +148,7 @@ private fun SetupGuiKeyboardBottomSheet(
                 buttonTextEnabled = stringResource(R.string.setup_gui_keyboard_install_keyboard_button),
                 buttonTextDisabled = stringResource(R.string.setup_gui_keyboard_install_keyboard_button_disabled),
                 onButtonClick = {
-                    uriHandler.openUri(guiKeyboardUrl)
+                    uriHandler.openUriSafe(ctx, guiKeyboardUrl)
                 },
             )
 

app/src/main/java/io/github/sds100/keymapper/mappings/keymaps/trigger/TriggerKeyOptionsBottomSheet.kt

@@ -27,6 +27,7 @@ import androidx.compose.runtime.Composable
 import androidx.compose.runtime.rememberCoroutineScope
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.platform.LocalDensity
 import androidx.compose.ui.platform.LocalUriHandler
 import androidx.compose.ui.res.stringResource
@@ -40,6 +41,7 @@ import io.github.sds100.keymapper.mappings.FingerprintGestureType
 import io.github.sds100.keymapper.util.ui.CheckBoxListItem
 import io.github.sds100.keymapper.util.ui.compose.CheckBoxText
 import io.github.sds100.keymapper.util.ui.compose.RadioButtonText
+import io.github.sds100.keymapper.util.ui.compose.openUriSafe
 import kotlinx.coroutines.launch
 
 @OptIn(ExperimentalMaterial3Api::class)
@@ -65,6 +67,7 @@ fun TriggerKeyOptionsBottomSheet(
         dragHandle = {},
     ) {
         val uriHandler = LocalUriHandler.current
+        val ctx = LocalContext.current
         val helpUrl = stringResource(R.string.url_trigger_key_options_guide)
         val scope = rememberCoroutineScope()
 
@@ -82,7 +85,7 @@ fun TriggerKeyOptionsBottomSheet(
                     modifier = Modifier
                         .align(Alignment.TopEnd)
                         .padding(horizontal = 8.dp),
-                    onClick = { uriHandler.openUri(helpUrl) },
+                    onClick = { uriHandler.openUriSafe(ctx, helpUrl) },
                 ) {
                     Icon(
                         imageVector = Icons.AutoMirrored.Rounded.HelpOutline,

app/src/main/java/io/github/sds100/keymapper/util/ui/compose/UriHandlerUtils.kt

@@ -0,0 +1,15 @@
+package io.github.sds100.keymapper.util.ui.compose
+
+import android.content.Context
+import android.widget.Toast
+import androidx.compose.ui.platform.UriHandler
+import io.github.sds100.keymapper.R
+import io.github.sds100.keymapper.util.str
+
+fun UriHandler.openUriSafe(ctx: Context, uri: String) {
+    try {
+        openUri(uri)
+    } catch (e: IllegalArgumentException) {
+        Toast.makeText(ctx, ctx.str(R.string.error_no_app_to_open_url), Toast.LENGTH_SHORT).show()
+    }
+}