#1637 give option to never show notification permission alert again

Author: sds100

app/src/main/java/io/github/sds100/keymapper/data/Keys.kt

@@ -93,4 +93,7 @@ object Keys {
      * Whether the user viewed the advanced triggers.
      */
     val viewedAdvancedTriggers = booleanPreferencesKey("key_viewed_advanced_triggers")
+
+    val neverShowNotificationPermissionAlert =
+        booleanPreferencesKey("key_never_show_notification_permission_alert")
 }

app/src/main/java/io/github/sds100/keymapper/home/ShowHomeScreenAlertsUseCase.kt

@@ -8,6 +8,7 @@ import io.github.sds100.keymapper.system.accessibility.ServiceState
 import io.github.sds100.keymapper.system.permissions.Permission
 import io.github.sds100.keymapper.system.permissions.PermissionAdapter
 import kotlinx.coroutines.flow.Flow
+import kotlinx.coroutines.flow.combine
 import kotlinx.coroutines.flow.map
 
 /**
@@ -53,12 +54,21 @@ class ShowHomeScreenAlertsUseCaseImpl(
         preferences.set(Keys.log, false)
     }
 
-    override val isNotificationPermissionGranted: Flow<Boolean> =
-        permissions.isGrantedFlow(Permission.POST_NOTIFICATIONS)
+    override val showNotificationPermissionAlert: Flow<Boolean> =
+        combine(
+            permissions.isGrantedFlow(Permission.POST_NOTIFICATIONS),
+            preferences.get(Keys.neverShowNotificationPermissionAlert).map { it ?: false },
+        ) { isGranted, neverShow ->
+            !isGranted && !neverShow
+        }
 
     override fun requestNotificationPermission() {
         permissions.request(Permission.POST_NOTIFICATIONS)
     }
+
+    override fun neverShowNotificationPermissionAlert() {
+        preferences.set(Keys.neverShowNotificationPermissionAlert, true)
+    }
 }
 
 interface ShowHomeScreenAlertsUseCase {
@@ -76,6 +86,7 @@ interface ShowHomeScreenAlertsUseCase {
     val isLoggingEnabled: Flow<Boolean>
     fun disableLogging()
 
-    val isNotificationPermissionGranted: Flow<Boolean>
+    val showNotificationPermissionAlert: Flow<Boolean>
     fun requestNotificationPermission()
+    fun neverShowNotificationPermissionAlert()
 }

app/src/main/java/io/github/sds100/keymapper/mappings/keymaps/KeyMapListViewModel.kt

@@ -153,8 +153,8 @@ class KeyMapListViewModel(
         showAlertsUseCase.accessibilityServiceState,
         showAlertsUseCase.hideAlerts,
         showAlertsUseCase.isLoggingEnabled,
-        showAlertsUseCase.isNotificationPermissionGranted,
-    ) { isBatteryOptimised, serviceState, isHidden, isLoggingEnabled, isNotificationPermissionGranted ->
+        showAlertsUseCase.showNotificationPermissionAlert,
+    ) { isBatteryOptimised, serviceState, isHidden, isLoggingEnabled, showNotificationPermissionAlert ->
         if (isHidden) {
             return@combine emptyList()
         }
@@ -189,7 +189,7 @@ class KeyMapListViewModel(
                 )
             } // don't show a success message for this
 
-            if (!isNotificationPermissionGranted) {
+            if (showNotificationPermissionAlert) {
                 add(
                     HomeWarningListItem(
                         ID_NOTIFICATION_PERMISSION_DENIED_LIST_ITEM,
@@ -683,11 +683,29 @@ class KeyMapListViewModel(
 
                 ID_BATTERY_OPTIMISATION_LIST_ITEM -> showAlertsUseCase.disableBatteryOptimisation()
                 ID_LOGGING_ENABLED_LIST_ITEM -> showAlertsUseCase.disableLogging()
-                ID_NOTIFICATION_PERMISSION_DENIED_LIST_ITEM -> showAlertsUseCase.requestNotificationPermission()
+                ID_NOTIFICATION_PERMISSION_DENIED_LIST_ITEM -> showNotificationPermissionAlertDialog()
             }
         }
     }
 
+    private suspend fun showNotificationPermissionAlertDialog() {
+        val dialog = PopupUi.Dialog(
+            title = getString(R.string.dialog_title_request_notification_permission),
+            message = getText(R.string.dialog_message_request_notification_permission),
+            positiveButtonText = getString(R.string.pos_turn_on),
+            negativeButtonText = getString(R.string.neg_no_thanks),
+            neutralButtonText = getString(R.string.pos_never_show_again),
+        )
+
+        val dialogResponse = showPopup("notification_permission_alert", dialog)
+
+        if (dialogResponse == DialogResponse.POSITIVE) {
+            showAlertsUseCase.requestNotificationPermission()
+        } else if (dialogResponse == DialogResponse.NEUTRAL) {
+            showAlertsUseCase.neverShowNotificationPermissionAlert()
+        }
+    }
+
     fun onTogglePausedClick() {
         coroutineScope.launch {
             if (pauseKeyMaps.isPaused.first()) {

app/src/main/java/io/github/sds100/keymapper/system/permissions/RequestPermissionDelegate.kt

@@ -11,6 +11,7 @@ import android.provider.Settings
 import androidx.activity.result.contract.ActivityResultContracts
 import androidx.annotation.RequiresApi
 import androidx.appcompat.app.AppCompatActivity
+import androidx.core.app.ActivityCompat
 import androidx.navigation.NavController
 import io.github.sds100.keymapper.Constants
 import io.github.sds100.keymapper.NavAppDirections
@@ -98,7 +99,23 @@ class RequestPermissionDelegate(
                 requestPermissionLauncher.launch(Manifest.permission.ACCESS_FINE_LOCATION)
 
             Permission.POST_NOTIFICATIONS -> if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
-                requestPermissionLauncher.launch(Manifest.permission.POST_NOTIFICATIONS)
+                val showRationale = ActivityCompat.shouldShowRequestPermissionRationale(
+                    activity,
+                    Manifest.permission.POST_NOTIFICATIONS,
+                )
+
+                // The system will say you have to show a rationale if the user previously
+                // denied the permission. Therefore, the permission dialog will not show and so
+                // open the notification settings to turn it on manually.
+                if (showRationale) {
+                    Intent(Settings.ACTION_APP_NOTIFICATION_SETTINGS).apply {
+                        putExtra(Settings.EXTRA_APP_PACKAGE, Constants.PACKAGE_NAME)
+
+                        activity.startActivity(this)
+                    }
+                } else {
+                    requestPermissionLauncher.launch(Manifest.permission.POST_NOTIFICATIONS)
+                }
             }
         }
     }

app/src/main/res/values/strings.xml

@@ -510,6 +510,9 @@
     <string name="dialog_title_keycode_to_scancode_trigger_explanation">Unrecognized key code</string>
     <string name="dialog_message_keycode_to_scancode_trigger_explanation">The pressed button was not recognized by the input system. In the past Key Mapper detected such buttons as one and the same. Currently the app tries to distinguish the button based on the scan code, which should be more unique. However, this is a makeshift incomplete solution, which doesn\'t guarantee uniqueness.</string>
 
+    <string name="dialog_title_request_notification_permission">Turn on notifications</string>
+    <string name="dialog_message_request_notification_permission">Some actions and options need this permission to work. You can also get notified when there is important news about the app.</string>
+
     <string name="pos_done">Done</string>
     <string name="pos_grant_write_secure_settings_guide">Guide</string>
     <string name="pos_start_service_with_adb_guide">Guide</string>
@@ -522,11 +525,13 @@
     <string name="pos_discard_changes">Discard changes</string>
     <string name="pos_save">Save</string>
     <string name="pos_understood">Understood</string>
+    <string name="pos_turn_on">Turn on</string>
 
     <string name="neg_turn_off">Turn off</string>
     <string name="neg_cancel">Cancel</string>
     <string name="neg_dont_show_again">Don\'t show again</string>
     <string name="neg_keep_editing">Keep editing</string>
+    <string name="neg_no_thanks">No thanks</string>
 
     <string name="neutral_hide">Hide</string>
     <string name="neutral_go_to_dont_kill_my_app">Online guide</string>