#1949 feat: floating buttons are completely invisible when pressed if background and border opacity is set to 0

Author: sds100

CHANGELOG.md

@@ -21,7 +21,8 @@
 - [#1982](https://github.com/keymapperorg/KeyMapper/issues/1982) Text action does not need Key Mapper input method on Android 13+.
 - [#1989](https://github.com/keymapperorg/KeyMapper/issues/1989) center the "Trigger and actions" and "Constraint and more" tabs.
 - [#1392](https://github.com/keymapperorg/KeyMapper/issues/1392) Add action to enable/disable/toggle night shift.
-- [#1675](https://github.com/keymapperorg/KeyMapper/issues/1675) Option to make floating buttons movable
+- [#1675](https://github.com/keymapperorg/KeyMapper/issues/1675) Option to make floating buttons movable.
+- [#1949](https://github.com/keymapperorg/KeyMapper/issues/1949) Floating buttons are completely invisible when pressed if background and border opacity is set to 0.
 
 ## [4.0.0 Beta 6](https://github.com/sds100/KeyMapper/releases/tag/v4.0.0-beta.06)
 

base/src/main/java/io/github/sds100/keymapper/base/home/KeyMapListItemCreator.kt

@@ -60,13 +60,16 @@ class KeyMapListItemCreator(
         val triggerKeys = keyMap.trigger.keys.map { key ->
             when (key) {
                 is AssistantTriggerKey -> assistantTriggerKeyName(key)
+
                 is KeyEventTriggerKey -> keyEventTriggerKeyName(
                     key,
                     showDeviceDescriptors,
                 )
 
                 is FloatingButtonKey -> floatingButtonKeyName(key)
+
                 is FingerprintTriggerKey -> fingerprintKeyName(key)
+
                 is EvdevTriggerKey -> evdevTriggerKeyName(key)
             }
         }
@@ -238,6 +241,13 @@ class KeyMapListItemCreator(
 
         if (key.button == null) {
             append(getString(R.string.deleted_floating_button_text_key_map_list_item))
+        } else if (key.button.appearance.text.isBlank()) {
+            append(
+                getString(
+                    R.string.floating_button_text_key_map_list_item_empty,
+                    key.button.layoutName,
+                ),
+            )
         } else {
             append(
                 getString(
@@ -265,7 +275,9 @@ class KeyMapListItemCreator(
 
         val deviceName = when (key.device) {
             is KeyEventTriggerDevice.Internal -> null
+
             is KeyEventTriggerDevice.Any -> getString(R.string.any_device)
+
             is KeyEventTriggerDevice.External -> {
                 if (showDeviceDescriptors) {
                     InputDeviceUtils.appendDeviceDescriptorToName(
@@ -349,12 +361,15 @@ class KeyMapListItemCreator(
             FingerprintGestureType.SWIPE_DOWN -> append(
                 getString(R.string.trigger_key_fingerprint_gesture_down),
             )
+
             FingerprintGestureType.SWIPE_UP -> append(
                 getString(R.string.trigger_key_fingerprint_gesture_up),
             )
+
             FingerprintGestureType.SWIPE_LEFT -> append(
                 getString(R.string.trigger_key_fingerprint_gesture_left),
             )
+
             FingerprintGestureType.SWIPE_RIGHT -> append(
                 getString(R.string.trigger_key_fingerprint_gesture_right),
             )

base/src/main/java/io/github/sds100/keymapper/base/trigger/TriggerKeyListItem.kt

@@ -142,10 +142,14 @@ fun TriggerKeyListItem(
                         )
                     }
 
-                    is TriggerKeyListItemModel.FloatingButton -> stringResource(
-                        R.string.trigger_key_floating_button_description,
-                        model.buttonName,
-                    )
+                    is TriggerKeyListItemModel.FloatingButton -> if (model.buttonName.isBlank()) {
+                        stringResource(R.string.trigger_key_floating_button_description_empty)
+                    } else {
+                        stringResource(
+                            R.string.trigger_key_floating_button_description,
+                            model.buttonName,
+                        )
+                    }
 
                     is TriggerKeyListItemModel.KeyEvent -> model.keyName
 

base/src/main/res/values/strings.xml

@@ -1428,19 +1428,19 @@
     <string name="floating_button_menu_configure">Configure</string>
     <string name="floating_button_menu_use_trigger">Use trigger</string>
     <string name="floating_button_config_delete_button">Delete</string>
-    <string name="floating_button_config_button_text_label">Button text (Tip: use an emoji)</string>
+    <string name="floating_button_config_button_text_label">Button text (optional) (Tip: use an emoji)</string>
     <string name="floating_button_config_button_size_label">Button size:</string>
     <string name="floating_button_config_border_opacity_label">Border opacity:</string>
     <string name="floating_button_config_background_opacity_label">Background opacity:</string>
     <string name="floating_button_config_cancel_button">Cancel</string>
     <string name="floating_button_config_done_button">Done</string>
-    <string name="floating_button_config_empty_text_error">The button must have text!</string>
     <string name="floating_button_config_show_over_status_bar">Show over notification panel</string>
     <string name="floating_button_config_show_over_input_method">Show over keyboard</string>
     <string name="floating_button_config_lock_position">Lock in position</string>
     <string name="floating_buttons_product_title">Floating buttons</string>
     <string name="floating_buttons_product_description">Floating buttons display over the apps you want. They work just like real buttons, and you can place, style, and map them however you like.</string>
     <string name="floating_button_text_key_map_list_item">Floating button %s (%s)</string>
+    <string name="floating_button_text_key_map_list_item_empty">Floating button (no text) (%s)</string>
     <string name="deleted_floating_button_text_key_map_list_item">Deleted floating button</string>
     <string name="tip_caps_lock_expert_mode_title">Better Caps Lock compatibility</string>
     <string name="tip_caps_lock_expert_mode_text">Expert Mode provides better compatibility for Caps Lock remapping. Tap \'Use Expert Mode\' and record it again.</string>
@@ -1584,6 +1584,7 @@
     <string name="trigger_key_shortcut_add_assistant">Side key trigger</string>
     <string name="trigger_key_shortcut_add_fingerprint_gesture">Fingerprint gesture</string>
     <string name="trigger_key_floating_button_description">Floating button: %s</string>
+    <string name="trigger_key_floating_button_description_empty">Floating button (no text)</string>
     <string name="trigger_key_fingerprint_gesture_up">Swipe up fingerprint reader</string>
     <string name="trigger_key_fingerprint_gesture_down">Swipe down fingerprint reader</string>
     <string name="trigger_key_fingerprint_gesture_left">Swipe left fingerprint reader</string>