Feature/upstream 4.2 merge

[khakers]

Merges new upstream modmail changes
These were merged into modmail as mostly 2 large commits and thus largely unreviewable when cherry picking

Issue list:

• Double logging (1 is writing to console with the wrong format)
• snooze query specificity
• snooze data type refactor
• a number of errors and exceptions are logged at the debug or info level
• Save forwarded message data in mongoDB

[khakers]

Appears to be a double logging issue present right now

[khakers]

Found problems in the snooze implementation from modmail
working on:

• Fix snooze query specificity (they currently select the first thread in the database for a given user)
• Use mongodb timestamps instead of strings
• send user thread messages with a webhook instead of the current simple message format so they appear to have come from that user.

[khakers]

Double logging issue has been fix, it was due to all the snooze code using logging.<level> instead of logger.<level>.

[Copilot]

Pull request overview

This PR merges upstream Modmail 4.2 changes into the fork, incorporating upstream fixes (logging/typing/forwarded messages) and introducing new user-facing features (snoozing and thread-creation menu) along with dependency/version updates.

Changes:

• Bump project version to 5.0.0-alpha.1, update core dependencies (notably discord-py and aiohttp), and adjust licensing/lockfile.
• Add/extend Modmail features: snooze/unsnooze flows, thread minimum character enforcement, forwarded-message extraction/relay, and a new core threadmenu cog/config.
• Improve operational behavior: “safe typing” wrapper, logging formatter tweaks, pagination lifecycle changes, and various embed/icon_url robustness updates.

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pyproject.toml	Version bump, dependency updates, license field adjustments.
pdm.lock	Lockfile regenerated to reflect updated dependencies and new packages.
core/utils.py	Adds safe_typing, forwarded-content extraction helpers, button custom_id changes.
core/time.py	Tweaks time parsing heuristics and punctuation handling for more user-friendly parsing.
core/paginator.py	Makes paginator non-blocking by waiting/closing in a background task; refactors stop button setup.
core/models.py	Logging formatting updates; disables discord logger propagation to avoid double-logging.
core/config_help.json	Documents new config options (thread menu, snooze, min characters).
core/config.py	Adds new config defaults and conversion rules (duration seconds, channel/category parsing).
core/clients.py	Type annotations and small robustness tweaks for avatar URL fields; formatting changes.
core/changelog.py	Makes avatar URL usage safer when generating embeds.
core/_color_data.py	Removes stray whitespace.
cogs/utility.py	Various embed formatting changes; config listing pagination; alias safety checks; new alias/snippet rename commands.
cogs/threadmenu.py	New cog implementing core thread-creation menu configuration commands.
cogs/plugins.py	Uses safe_typing, updates docs link, and formatting improvements.
cogs/modmail.py	Large snooze/unsnooze feature addition and behavior changes.
bot.py	Version update; DM message ordering queue; forwarded-message handling; additional snooze behaviors; internal logging changes.
CHANGELOG.md	Documents new snooze + threadmenu capabilities and several upstream fixes.
.github/FUNDING.yml	Removes funding configuration.
.gitattributes	Adds default text normalization.
.env.example	Adds DISABLE_AUTOUPDATES example variable.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Merges upstream Modmail 4.2 changes into this fork, including updated dependencies, new/expanded thread workflow features (snooze + thread-creation menu), and multiple robustness improvements around logging, typing indicators, and message handling (including forwarded messages).

Changes:

• Bump project version/dependencies and adjust packaging metadata (license, new deps, updated lockfile).
• Add/extend configuration surface and commands for snoozing threads and for an interactive thread-creation menu (new threadmenu cog + new config keys/help text).
• Improve operational robustness (typing failures tolerated, DM ordering queue, forwarded-message handling, logging format/handlers, paginator non-blocking behavior).

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
pyproject.toml	Version bump, dependency updates, add license + lottie dependency.
pdm.lock	Lockfile update to match dependency changes.
core/utils.py	Add safe typing context manager, forwarded-content extraction helper, UI button API adjustments.
core/time.py	Parsing heuristics/formatting tweaks for user-friendly time handling.
core/paginator.py	Make paginator non-blocking by backgrounding view wait/close; UI button refactor.
core/models.py	Logging formatter updates, handler config tweaks (incl. propagate=False).
core/config_help.json	Document new config options (thread menu, snooze, min characters, etc.).
core/config.py	Add new config defaults/typing (colors/booleans/duration parsing); config parsing tweaks.
core/clients.py	Persist additional forwarded message metadata into Mongo logs; typing hints.
core/changelog.py	Guard avatar URL usage when building changelog embeds.
core/_color_data.py	Minor formatting cleanup.
cogs/utility.py	Help/config UX adjustments; paginator usage updates; misc formatting changes.
cogs/threadmenu.py	New core cog implementing thread menu configuration commands & import/export.
cogs/plugins.py	Update docs link, safer typing usage, misc formatting changes.
cogs/modmail.py	Major feature additions/changes (snooze commands, snippet UX updates, typing safety changes).
bot.py	Version bump, add DM processing queue, forwarded-message handling, autoupdate/metadata tasks, various robustness tweaks.
CHANGELOG.md	Document new features/config options and fixes.
.github/FUNDING.yml	Remove funding config.
.gitattributes	Add default text normalization rule.
.env.example	Add DISABLE_AUTOUPDATES example env var.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

threadmenu_show/threadmenu_option_show pass v["description"] and v["emoji"] directly to Embed.add_field. These are optional in the wizard (can be None), but add_field expects strings and will raise if given None. Please coerce missing values to a safe default (e.g. empty string or "(none)") before adding fields.

Suggested change

	embed.add_field(name=v["label"], value=v["description"], inline=False)
	description = v.get("description")
	if description is None:
	description = "(none)"
	embed.add_field(name=v["label"], value=description, inline=False)

[Copilot]

The typecheck predicate only allows "command"/"submenu", but later code checks for type_ == "cancel". As-is, users cannot cancel at this prompt (their "cancel" message will never pass the wait_for check). Please either include "cancel" in the allowed inputs or add a timeout and a separate cancellation handling path.

Suggested change

	"submenu",
	"submenu",
	"cancel",

[Copilot]

message.reference.type.name and iterating message.message_snapshots are not guarded. If reference.type is None/missing (or message_snapshots isn’t present on the message object), append_log will raise and break logging for normal messages. Please use getattr/hasattr with safe fallbacks (e.g., getattr(message, "message_snapshots", [])) and defensively handle missing/None reference.type.

[Copilot]

auto_unsnooze_task caches only records with snooze_until >= now, so threads that became due while the bot was offline (i.e., snooze_until < now) will never be picked up by this task after restart. Also, this file contains a second auto-unsnooze loop (snooze_auto_unsnooze), meaning two independent unsnooze schedulers can run at once. Please consolidate to a single scheduler and ensure the DB query selects due threads ($lte now) when appropriate.

Suggested change

	{"snooze_until": {"$gte": now}},
	{"snooze_until": {"$lte": now}},

[khakers]

Need to do testing for this case

[Copilot]

The changelog lists a max_snooze_time configuration option, but the config defaults/validation keys added in this PR use snooze_default_duration (and the snooze command currently clamps duration to that default). Please either implement and document max_snooze_time end-to-end, or update the changelog to reflect the actual config keys/behavior.