Added a new hint BINARY_MODE to allow working with binary QRCodes.#158
Merged
Conversation
…created a test and fixed nullable parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
mb_convert_encoding()was added to DecodedBitStreamParser.php, QRCodes containing binary data with non-printable bytes stopped working.This PR adds a new hint
BINARY_MODEthat, when used, reverts to the previous mode of just appending the string without encoding conversion. This also adds a test case for QRCodes containing binary data.Result->getRawBytes()is not an viable alternative because it keeps padding characters.