Fix sqlite order by args#1
Open
khepin wants to merge 23 commits into
Open
Conversation
* origin/main: (91 commits) build(deps): bump urllib3 from 2.6.2 to 2.6.3 in /docs (sqlc-dev#4259) build(deps): bump golang from 1.26.0 to 1.26.1 (sqlc-dev#4328) build(deps): bump the production-dependencies group across 1 directory with 4 updates (sqlc-dev#4348) Upgrade Go version to 1.26.0 (sqlc-dev#4312) Install PostgreSQL from theseus-rs/postgresql-binaries instead of apt (sqlc-dev#4310) build(deps): bump golang from 1.25.5 to 1.26.0 (sqlc-dev#4294) build(deps): bump the production-dependencies group across 1 directory with 2 updates (sqlc-dev#4296) Add sqlc-test-setup command for database test environment setup (sqlc-dev#4304) build(deps): bump filippo.io/edwards25519 from 1.1.0 to 1.1.1 (sqlc-dev#4303) build(deps): bump the production-dependencies group across 1 directory with 4 updates (sqlc-dev#4284) feat: add ClickHouse support to `sqlc parse` (sqlc-dev#4267) Add GitHub Topic to the plugins page (sqlc-dev#4258) build(deps): bump the production-dependencies group across 1 directory with 2 updates (sqlc-dev#4256) build(deps): bump the production-dependencies group across 1 directory with 4 updates (sqlc-dev#4248) fix(native): make MySQL connection check immediate on first attempt (sqlc-dev#4254) feat: graduate parsecmd experiment (sqlc-dev#4253) docs: Add Claude Code remote environment setup instructions (sqlc-dev#4246) Add parse subcommand with AST JSON output (sqlc-dev#4240) feat(postgresql): add analyzerv2 experiment for database-only analysis (sqlc-dev#4237) feat: add native database support for e2e tests without Docker (sqlc-dev#4236) ... # Conflicts: # internal/engine/sqlite/convert.go
* validateOnConflictColumns * validateOnConflictTypes * validateOnConflictClause * remove validateOnConflictSetTypes * move to validate * params order * ON CONSTRAINT
…ev#4377) Bumps [github.com/jackc/pgx/v5](https://github.com/jackc/pgx) from 5.8.0 to 5.9.0. - [Changelog](https://github.com/jackc/pgx/blob/master/CHANGELOG.md) - [Commits](jackc/pgx@v5.8.0...v5.9.0) --- updated-dependencies: - dependency-name: github.com/jackc/pgx/v5 dependency-version: 5.9.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v6...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the Go toolchain used in CI, Docker, and documentation to 1.26.2. The go directive in go.mod remains at 1.26.0 (minimum required version); a toolchain directive is added to pin the build toolchain to go1.26.2. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
sqlc's own code no longer needs pgx/v4 at build time: - Delete internal/sqltest/pgx.go — the PostgreSQLPgx helper had no callers. - Migrate the sqlc-pg-gen internal tool from pgx/v4 to pgx/v5; the Connect/Query/Scan API surface used here is identical. pgx/v4 remains a supported code-generation target for sqlc users (SQLDriverPGXV4 constant and the imports emitted into generated code are unchanged); only sqlc's own dependency on the library is removed. go mod tidy also drops chunkreader/v2, pgconn, pgio, pgproto3/v2, pgtype, and golang.org/x/crypto as transitively unused. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
) Bumps [requests](https://github.com/psf/requests) from 2.32.5 to 2.33.0. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.5...v2.33.0) --- updated-dependencies: - dependency-name: requests dependency-version: 2.33.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [pygments](https://github.com/pygments/pygments) from 2.19.2 to 2.20.0. - [Release notes](https://github.com/pygments/pygments/releases) - [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES) - [Commits](pygments/pygments@2.19.2...2.20.0) --- updated-dependencies: - dependency-name: pygments dependency-version: 2.20.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…y with 5 updates (sqlc-dev#4368) * build(deps): bump the production-dependencies group across 1 directory with 5 updates Bumps the production-dependencies group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [github.com/google/cel-go](https://github.com/google/cel-go) | `0.27.0` | `0.28.0` | | [github.com/jackc/pgx/v5](https://github.com/jackc/pgx) | `5.8.0` | `5.9.1` | | [github.com/lib/pq](https://github.com/lib/pq) | `1.12.0` | `1.12.3` | | [github.com/ncruces/go-sqlite3](https://github.com/ncruces/go-sqlite3) | `0.32.0` | `0.33.2` | | [google.golang.org/grpc](https://github.com/grpc/grpc-go) | `1.79.3` | `1.80.0` | Updates `github.com/google/cel-go` from 0.27.0 to 0.28.0 - [Release notes](https://github.com/google/cel-go/releases) - [Commits](cel-expr/cel-go@v0.27.0...v0.28.0) Updates `github.com/jackc/pgx/v5` from 5.8.0 to 5.9.1 - [Changelog](https://github.com/jackc/pgx/blob/master/CHANGELOG.md) - [Commits](jackc/pgx@v5.8.0...v5.9.1) Updates `github.com/lib/pq` from 1.12.0 to 1.12.3 - [Release notes](https://github.com/lib/pq/releases) - [Changelog](https://github.com/lib/pq/blob/master/CHANGELOG.md) - [Commits](lib/pq@v1.12.0...v1.12.3) Updates `github.com/ncruces/go-sqlite3` from 0.32.0 to 0.33.2 - [Release notes](https://github.com/ncruces/go-sqlite3/releases) - [Commits](ncruces/go-sqlite3@v0.32.0...v0.33.2) Updates `google.golang.org/grpc` from 1.79.3 to 1.80.0 - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.79.3...v1.80.0) --- updated-dependencies: - dependency-name: github.com/google/cel-go dependency-version: 0.28.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies - dependency-name: github.com/jackc/pgx/v5 dependency-version: 5.9.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies - dependency-name: github.com/lib/pq dependency-version: 1.12.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: production-dependencies - dependency-name: github.com/ncruces/go-sqlite3 dependency-version: 0.33.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies - dependency-name: google.golang.org/grpc dependency-version: 1.80.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> * Drop github.com/ncruces/go-sqlite3/embed import ncruces/go-sqlite3 v0.33 replaced its embedded wasm runtime with a pure-Go translation (via wasm2go) in the new module github.com/ncruces/go-sqlite3-wasm. The embed subpackage that used to initialize sqlite3.Binary at import time no longer exists, so the blank imports break the build. SQLite is now wired in automatically as a transitive dep. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kyle Conroy <kyle@conroy.org> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…y with 11 updates (sqlc-dev#4380) * build(deps): bump the production-dependencies group across 1 directory with 11 updates Bumps the production-dependencies group with 11 updates in the /docs directory: | Package | From | To | | --- | --- | --- | | [babel](https://github.com/python-babel/babel) | `2.17.0` | `2.18.0` | | [certifi](https://github.com/certifi/python-certifi) | `2026.1.4` | `2026.2.25` | | [chardet](https://github.com/chardet/chardet) | `5.2.0` | `7.4.3` | | [imagesize](https://github.com/shibukawa/imagesize_py) | `1.4.1` | `2.0.0` | | [myst-parser](https://github.com/executablebooks/MyST-Parser) | `4.0.1` | `5.0.0` | | [packaging](https://github.com/pypa/packaging) | `25.0` | `26.1` | | [pyparsing](https://github.com/pyparsing/pyparsing) | `3.3.1` | `3.3.2` | | [pytz](https://github.com/stub42/pytz) | `2025.2` | `2026.1.post1` | | [requests](https://github.com/psf/requests) | `2.33.0` | `2.33.1` | | [sphinx-favicon](https://github.com/tcmetzger/sphinx-favicon) | `1.0.1` | `1.1.0` | | [sphinx-rtd-theme](https://github.com/readthedocs/sphinx_rtd_theme) | `3.0.2` | `3.1.0` | Updates `babel` from 2.17.0 to 2.18.0 - [Release notes](https://github.com/python-babel/babel/releases) - [Changelog](https://github.com/python-babel/babel/blob/master/CHANGES.rst) - [Commits](python-babel/babel@v2.17.0...v2.18.0) Updates `certifi` from 2026.1.4 to 2026.2.25 - [Commits](certifi/python-certifi@2026.01.04...2026.02.25) Updates `chardet` from 5.2.0 to 7.4.3 - [Release notes](https://github.com/chardet/chardet/releases) - [Changelog](https://github.com/chardet/chardet/blob/main/docs/changelog.rst) - [Commits](chardet/chardet@5.2.0...7.4.3) Updates `imagesize` from 1.4.1 to 2.0.0 - [Commits](shibukawa/imagesize_py@1.4.1...2.0.0) Updates `myst-parser` from 4.0.1 to 5.0.0 - [Release notes](https://github.com/executablebooks/MyST-Parser/releases) - [Changelog](https://github.com/executablebooks/MyST-Parser/blob/master/CHANGELOG.md) - [Commits](executablebooks/MyST-Parser@v4.0.1...v5.0.0) Updates `packaging` from 25.0 to 26.1 - [Release notes](https://github.com/pypa/packaging/releases) - [Changelog](https://github.com/pypa/packaging/blob/main/CHANGELOG.rst) - [Commits](pypa/packaging@25.0...26.1) Updates `pyparsing` from 3.3.1 to 3.3.2 - [Release notes](https://github.com/pyparsing/pyparsing/releases) - [Changelog](https://github.com/pyparsing/pyparsing/blob/master/CHANGES) - [Commits](pyparsing/pyparsing@3.3.1...3.3.2) Updates `pytz` from 2025.2 to 2026.1.post1 - [Release notes](https://github.com/stub42/pytz/releases) - [Commits](stub42/pytz@release_2025.2...release_2026.1.post1) Updates `requests` from 2.33.0 to 2.33.1 - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.33.0...v2.33.1) Updates `sphinx-favicon` from 1.0.1 to 1.1.0 - [Release notes](https://github.com/tcmetzger/sphinx-favicon/releases) - [Changelog](https://github.com/tcmetzger/sphinx-favicon/blob/main/CHANGELOG) - [Commits](tcmetzger/sphinx-favicon@v1.0.1...v1.1.0) Updates `sphinx-rtd-theme` from 3.0.2 to 3.1.0 - [Changelog](https://github.com/readthedocs/sphinx_rtd_theme/blob/master/docs/changelog.rst) - [Commits](readthedocs/sphinx_rtd_theme@3.0.2...3.1.0) --- updated-dependencies: - dependency-name: babel dependency-version: 2.18.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies - dependency-name: certifi dependency-version: 2026.2.25 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies - dependency-name: chardet dependency-version: 7.4.3 dependency-type: direct:production update-type: version-update:semver-major dependency-group: production-dependencies - dependency-name: imagesize dependency-version: 2.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: production-dependencies - dependency-name: myst-parser dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: production-dependencies - dependency-name: packaging dependency-version: '26.1' dependency-type: direct:production update-type: version-update:semver-major dependency-group: production-dependencies - dependency-name: pyparsing dependency-version: 3.3.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: production-dependencies - dependency-name: pytz dependency-version: 2026.1.post1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: production-dependencies - dependency-name: requests dependency-version: 2.33.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: production-dependencies - dependency-name: sphinx-favicon dependency-version: 1.1.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies - dependency-name: sphinx-rtd-theme dependency-version: 3.1.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> * Bump Sphinx to 8.2.3 to satisfy myst-parser 5.0.0 myst-parser 5.0.0 requires sphinx>=8,<10, but docs/requirements.txt was still pinning Sphinx==7.4.7, so pip couldn't resolve the environment and the Read the Docs build failed before sphinx-build ran. Bumping to the latest 8.x resolves the conflict. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kyle Conroy <kyle@conroy.org> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Add paths-ignore for docs/** and .readthedocs.yaml to the go, buf, kotlin, python, and typescript workflows so doc-only PRs don't spin up the Go test matrix. - Add a Read the Docs post_checkout hook that exits 183 (the documented "cancel build successfully" code) for PR builds that don't touch docs/ or .readthedocs.yaml, mirroring the inverse on the RTD side. Note: if any of the skipped checks are currently listed as required in branch protection, doc-only PRs will block waiting for them. Flip those to non-required, or add a matching no-op workflow that runs under the ignored paths, as a follow-up. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* Preserve MySQL optimizer hints in stripped query text Fixes sqlc-dev#4353. Hint comments (/*+ ... */) on their own line were being treated as regular block comments and removed from the query string embedded in generated code. Inline hints already survived because the surrounding line did not match the block-comment pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Drop unit test; end-to-end coverage is sufficient Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…te-order-by-args * 'main' of https://github.com/sqlc-dev/sqlc: Map xid8 to pgtype.Uint64 for pgx/v5 (sqlc-dev#4387) Rename :one return variable when it conflicts with a parameter (sqlc-dev#4383) Coerce SQLite JSONB output regardless of type casing (sqlc-dev#4385) Dedupe sqlc.arg parameters wrapped in a type cast for MySQL (sqlc-dev#4384) Preserve MySQL optimizer hints in generated query text (sqlc-dev#4382) Skip CI/RTD builds when the change is irrelevant (sqlc-dev#4381) build(deps): bump the production-dependencies group across 1 directory with 11 updates (sqlc-dev#4380) build(deps): bump the production-dependencies group across 1 directory with 5 updates (sqlc-dev#4368) build(deps): bump pygments from 2.19.2 to 2.20.0 in /docs (sqlc-dev#4363) build(deps): bump requests from 2.32.5 to 2.33.0 in /docs (sqlc-dev#4357) Remove github.com/jackc/pgx/v4 dependency (sqlc-dev#4379) Upgrade Go toolchain to 1.26.2 (sqlc-dev#4378) build(deps): bump actions/upload-artifact from 6 to 7 (sqlc-dev#4320) docs: add sqlc-gen-sqlx to community language support (sqlc-dev#4371) build(deps): bump github.com/jackc/pgx/v5 from 5.8.0 to 5.9.0 (sqlc-dev#4377) Catch invalid ON CONFLICT DO UPDATE column references (sqlc-dev#4366)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.