fix: docker run reliability and workflow DEFAULT outcome handling

- Re-download stale runtime cache when PAD files are missing (fixes
  builds that fail with missing StudioPro.conf.hbs after interrupted
  downloads)
- Clean up partial MxBuild/runtime cache before re-downloading (fixes
  silent re-download when kill interrupts extraction)
- Drop DEFAULT outcomes from boolean workflow decisions at write time;
  Mendix 11 runtime rejects VoidConditionOutcome for boolean conditions
- Guard against nil-panic in visitor when DROP OUTCOME/PATH has invalid
  syntax
- Use %PROGRAMFILES% env vars for MxBuild/JDK search on Windows instead
  of hardcoded C:\Program Files

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: engalar

cmd/mxcli/docker/build.go

@@ -641,9 +641,18 @@ func ensurePADFiles(productVersion string, w io.Writer) error {
 		return nil
 	}
 
-	// Check that the runtime PAD source exists
+	// Check that the runtime PAD source exists; if not, the cached runtime is stale
+	// (downloaded before PAD files were included). Invalidate and re-download.
 	if _, err := os.Stat(runtimePAD); err != nil {
-		return fmt.Errorf("runtime PAD files not found at %s", runtimePAD)
+		fmt.Fprintf(w, "  PAD files missing from cached runtime, re-downloading...\n")
+		os.RemoveAll(runtimeDir)
+		if _, err := DownloadRuntime(productVersion, w); err != nil {
+			return fmt.Errorf("re-downloading runtime for PAD files: %w", err)
+		}
+		// Check again — some versions simply don't ship PAD files.
+		if _, err := os.Stat(runtimePAD); err != nil {
+			return fmt.Errorf("runtime PAD files not found at %s (not included in this Mendix version)", runtimePAD)
+		}
 	}
 
 	// Create parent directory if needed

cmd/mxcli/docker/detect.go

@@ -94,10 +94,18 @@ func resolveMxBuild(explicitPath string) (string, error) {
 func mxbuildSearchPaths() []string {
 	switch runtime.GOOS {
 	case "windows":
-		return []string{
-			`C:\Program Files\Mendix\*\modeler\mxbuild.exe`,
-			`C:\Program Files (x86)\Mendix\*\modeler\mxbuild.exe`,
+		var paths []string
+		// Use environment variables — the system drive is not always C:.
+		for _, env := range []string{"PROGRAMFILES", "PROGRAMW6432", "PROGRAMFILES(X86)"} {
+			if dir := os.Getenv(env); dir != "" {
+				paths = append(paths, filepath.Join(dir, "Mendix", "*", "modeler", "mxbuild.exe"))
+			}
 		}
+		if len(paths) == 0 {
+			// Fallback if env vars are missing (unlikely but safe).
+			paths = []string{`C:\Program Files\Mendix\*\modeler\mxbuild.exe`}
+		}
+		return paths
 	case "darwin":
 		return []string{
 			"/Applications/Mendix/*/modeler/mxbuild",
@@ -174,11 +182,20 @@ func resolveMacOSJavaHome() (string, error) {
 func jdkSearchPaths() []string {
 	switch runtime.GOOS {
 	case "windows":
-		return []string{
-			`C:\Program Files\Eclipse Adoptium\jdk-21*`,
-			`C:\Program Files\Java\jdk-21*`,
-			`C:\Program Files\Microsoft\jdk-21*`,
+		var paths []string
+		for _, env := range []string{"PROGRAMFILES", "PROGRAMW6432"} {
+			if dir := os.Getenv(env); dir != "" {
+				paths = append(paths,
+					filepath.Join(dir, "Eclipse Adoptium", "jdk-21*"),
+					filepath.Join(dir, "Java", "jdk-21*"),
+					filepath.Join(dir, "Microsoft", "jdk-21*"),
+				)
+			}
 		}
+		if len(paths) == 0 {
+			paths = []string{`C:\Program Files\Eclipse Adoptium\jdk-21*`}
+		}
+		return paths
 	case "darwin":
 		return []string{
 			"/Library/Java/JavaVirtualMachines/temurin-21*/Contents/Home",

cmd/mxcli/docker/download.go

@@ -86,6 +86,12 @@ func DownloadMxBuild(version string, w io.Writer) (string, error) {
 		return "", err
 	}
 
+	// Remove any partial cache from a previously interrupted download.
+	if _, err := os.Stat(cacheDir); err == nil {
+		fmt.Fprintf(w, "  Removing incomplete cache at %s...\n", cacheDir)
+		os.RemoveAll(cacheDir)
+	}
+
 	url := MxBuildCDNURL(version, runtime.GOARCH)
 	fmt.Fprintf(w, "  Downloading MxBuild %s for %s...\n", version, runtime.GOARCH)
 	fmt.Fprintf(w, "  URL: %s\n", url)
@@ -182,6 +188,12 @@ func DownloadRuntime(version string, w io.Writer) (string, error) {
 		return "", err
 	}
 
+	// Remove any partial cache from a previously interrupted download.
+	if _, err := os.Stat(cacheDir); err == nil {
+		fmt.Fprintf(w, "  Removing incomplete cache at %s...\n", cacheDir)
+		os.RemoveAll(cacheDir)
+	}
+
 	url := RuntimeCDNURL(version)
 	fmt.Fprintf(w, "  Downloading Mendix runtime %s...\n", version)
 	fmt.Fprintf(w, "  URL: %s\n", url)

mdl/executor/cmd_workflows_write.go

@@ -351,7 +351,22 @@ func buildExclusiveSplit(n *ast.WorkflowDecisionNode) *workflows.ExclusiveSplitA
 	}
 	act.Name = act.Caption
 
+	// Detect boolean decision (has TRUE or FALSE outcomes).
+	// The Mendix 11 runtime only supports BooleanConditionOutcome and
+	// EnumerationValueConditionOutcome — VoidConditionOutcome (DEFAULT) is rejected.
+	isBooleanDecision := false
+	for _, o := range n.Outcomes {
+		if o.Value == "True" || o.Value == "False" {
+			isBooleanDecision = true
+			break
+		}
+	}
+
 	for _, outcomeNode := range n.Outcomes {
+		if isBooleanDecision && outcomeNode.Value == "Default" {
+			// Skip DEFAULT on boolean decisions — runtime rejects VoidConditionOutcome.
+			continue
+		}
 		outcome := buildConditionOutcome(outcomeNode)
 		if outcome != nil {
 			act.Outcomes = append(act.Outcomes, outcome)

mdl/visitor/visitor_workflow.go

@@ -195,6 +195,9 @@ func buildAlterWorkflowAction(ctx *parser.AlterWorkflowActionContext) ast.AlterW
 
 	// DROP OUTCOME 'name' ON alterActivityRef
 	if ctx.DROP() != nil && ctx.OUTCOME() != nil {
+		if ctx.AlterActivityRef() == nil || ctx.STRING_LITERAL() == nil {
+			return nil
+		}
 		ref, atPos := parseAlterActivityRef(ctx.AlterActivityRef().(*parser.AlterActivityRefContext))
 		outcomeName := unquoteString(ctx.STRING_LITERAL().GetText())
 		return &ast.DropOutcomeOp{
@@ -206,6 +209,9 @@ func buildAlterWorkflowAction(ctx *parser.AlterWorkflowActionContext) ast.AlterW
 
 	// DROP PATH 'caption' ON alterActivityRef
 	if ctx.DROP() != nil && ctx.PATH() != nil && ctx.BOUNDARY() == nil {
+		if ctx.AlterActivityRef() == nil || ctx.STRING_LITERAL() == nil {
+			return nil
+		}
 		ref, atPos := parseAlterActivityRef(ctx.AlterActivityRef().(*parser.AlterActivityRefContext))
 		pathCaption := unquoteString(ctx.STRING_LITERAL().GetText())
 		return &ast.DropPathOp{