feat: support full user targeting on workflow USER TASK (fixes mendixlabs#169)

Parser now reads both legacy UserSource and current UserTargeting BSON
fields, recognizing all five $Type variants: MicroflowUserTargeting,
XPathUserTargeting, MicroflowGroupTargeting, XPathGroupTargeting, and
NoUserTargeting. MDL syntax extended with optional USERS/GROUPS modifier:
TARGETING [USERS|GROUPS] MICROFLOW/XPATH.

Author: engalar

cmd/mxcli/lsp_completions_gen.go

@@ -56,10 +56,11 @@ type WorkflowUserTaskNode struct {
 func (n *WorkflowUserTaskNode) workflowActivityNode() {}
 
 // WorkflowTargetingNode represents user targeting strategy.
+// Kind: "microflow", "xpath", "group_microflow", "group_xpath", or ""
 type WorkflowTargetingNode struct {
-	Kind      string        // "microflow", "xpath", or ""
-	Microflow QualifiedName // for microflow targeting
-	XPath     string        // for xpath targeting
+	Kind      string        // "microflow", "xpath", "group_microflow", "group_xpath", or ""
+	Microflow QualifiedName // for microflow targeting (user or group)
+	XPath     string        // for xpath targeting (user or group)
 }
 
 // WorkflowUserTaskOutcomeNode represents an outcome of a user task.

mdl/ast/ast_workflow.go

@@ -432,6 +432,14 @@ func formatUserTask(a *workflows.UserTask, indent string) []string {
 			if us.XPath != "" {
 				lines = append(lines, fmt.Sprintf("%s  targeting xpath '%s'", indent, us.XPath))
 			}
+		case *workflows.MicroflowGroupSource:
+			if us.Microflow != "" {
+				lines = append(lines, fmt.Sprintf("%s  TARGETING GROUPS MICROFLOW %s", indent, us.Microflow))
+			}
+		case *workflows.XPathGroupSource:
+			if us.XPath != "" {
+				lines = append(lines, fmt.Sprintf("%s  TARGETING GROUPS XPATH '%s'", indent, us.XPath))
+			}
 		}
 	}
 

mdl/executor/cmd_workflows.go

@@ -251,6 +251,14 @@ func buildUserTask(n *ast.WorkflowUserTaskNode) *workflows.UserTask {
 		task.UserSource = &workflows.XPathBasedUserSource{
 			XPath: n.Targeting.XPath,
 		}
+	case "group_microflow":
+		task.UserSource = &workflows.MicroflowGroupSource{
+			Microflow: n.Targeting.Microflow.Module + "." + n.Targeting.Microflow.Name,
+		}
+	case "group_xpath":
+		task.UserSource = &workflows.XPathGroupSource{
+			XPath: n.Targeting.XPath,
+		}
 	}
 
 	// Outcomes

mdl/executor/cmd_workflows_write.go

@@ -659,6 +659,7 @@ ACTIVITY: A C T I V I T Y;
 CONDITION: C O N D I T I O N;
 OFF: O F F;
 USERS: U S E R S;
+GROUPS: G R O U P S;
 
 // Data transformer tokens
 DATA: D A T A;

mdl/grammar/MDLLexer.g4

@@ -2820,17 +2820,17 @@ workflowActivityStmt
 workflowUserTaskStmt
     : USER TASK IDENTIFIER STRING_LITERAL
       (PAGE qualifiedName)?
-      (TARGETING MICROFLOW qualifiedName)?
-      (TARGETING XPATH STRING_LITERAL)?
+      (TARGETING (USERS | GROUPS)? MICROFLOW qualifiedName)?
+      (TARGETING (USERS | GROUPS)? XPATH STRING_LITERAL)?
       (ENTITY qualifiedName)?
       (DUE DATE_TYPE STRING_LITERAL)?
       (DESCRIPTION STRING_LITERAL)?
       (OUTCOMES workflowUserTaskOutcome+)?
       (BOUNDARY EVENT workflowBoundaryEventClause+)?
     | MULTI USER TASK IDENTIFIER STRING_LITERAL
       (PAGE qualifiedName)?
-      (TARGETING MICROFLOW qualifiedName)?
-      (TARGETING XPATH STRING_LITERAL)?
+      (TARGETING (USERS | GROUPS)? MICROFLOW qualifiedName)?
+      (TARGETING (USERS | GROUPS)? XPATH STRING_LITERAL)?
       (ENTITY qualifiedName)?
       (DUE DATE_TYPE STRING_LITERAL)?
       (DESCRIPTION STRING_LITERAL)?

mdl/grammar/MDLParser.g4

@@ -514,84 +514,85 @@ ACTIVITY=513
 CONDITION=514
 OFF=515
 USERS=516
-DATA=517
-TRANSFORM=518
-TRANSFORMER=519
-TRANSFORMERS=520
-JSLT=521
-XSLT=522
-RECORDS=523
-NOTIFY=524
-PAUSE=525
-UNPAUSE=526
-ABORT=527
-RETRY=528
-RESTART=529
-LOCK=530
-UNLOCK=531
-REASON=532
-OPEN=533
-COMPLETE_TASK=534
-NOT_EQUALS=535
-LESS_THAN_OR_EQUAL=536
-GREATER_THAN_OR_EQUAL=537
-EQUALS=538
-LESS_THAN=539
-GREATER_THAN=540
-PLUS=541
-MINUS=542
-STAR=543
-SLASH=544
-PERCENT=545
-MOD=546
-DIV=547
-SEMICOLON=548
-COMMA=549
-DOT=550
-LPAREN=551
-RPAREN=552
-LBRACE=553
-RBRACE=554
-LBRACKET=555
-RBRACKET=556
-COLON=557
-AT=558
-PIPE=559
-DOUBLE_COLON=560
-ARROW=561
-QUESTION=562
-HASH=563
-MENDIX_TOKEN=564
-STRING_LITERAL=565
-DOLLAR_STRING=566
-NUMBER_LITERAL=567
-VARIABLE=568
-IDENTIFIER=569
-HYPHENATED_ID=570
-QUOTED_IDENTIFIER=571
-'<='=536
-'>='=537
-'='=538
-'<'=539
-'>'=540
-'+'=541
-'-'=542
-'*'=543
-'/'=544
-'%'=545
-';'=548
-','=549
-'.'=550
-'('=551
-')'=552
-'{'=553
-'}'=554
-'['=555
-']'=556
-':'=557
-'@'=558
-'|'=559
-'::'=560
-'->'=561
-'?'=562
-'#'=563
+GROUPS=517
+DATA=518
+TRANSFORM=519
+TRANSFORMER=520
+TRANSFORMERS=521
+JSLT=522
+XSLT=523
+RECORDS=524
+NOTIFY=525
+PAUSE=526
+UNPAUSE=527
+ABORT=528
+RETRY=529
+RESTART=530
+LOCK=531
+UNLOCK=532
+REASON=533
+OPEN=534
+COMPLETE_TASK=535
+NOT_EQUALS=536
+LESS_THAN_OR_EQUAL=537
+GREATER_THAN_OR_EQUAL=538
+EQUALS=539
+LESS_THAN=540
+GREATER_THAN=541
+PLUS=542
+MINUS=543
+STAR=544
+SLASH=545
+PERCENT=546
+MOD=547
+DIV=548
+SEMICOLON=549
+COMMA=550
+DOT=551
+LPAREN=552
+RPAREN=553
+LBRACE=554
+RBRACE=555
+LBRACKET=556
+RBRACKET=557
+COLON=558
+AT=559
+PIPE=560
+DOUBLE_COLON=561
+ARROW=562
+QUESTION=563
+HASH=564
+MENDIX_TOKEN=565
+STRING_LITERAL=566
+DOLLAR_STRING=567
+NUMBER_LITERAL=568
+VARIABLE=569
+IDENTIFIER=570
+HYPHENATED_ID=571
+QUOTED_IDENTIFIER=572
+'<='=537
+'>='=538
+'='=539
+'<'=540
+'>'=541
+'+'=542
+'-'=543
+'*'=544
+'/'=545
+'%'=546
+';'=549
+','=550
+'.'=551
+'('=552
+')'=553
+'{'=554
+'}'=555
+'['=556
+']'=557
+':'=558
+'@'=559
+'|'=560
+'::'=561
+'->'=562
+'?'=563
+'#'=564