Skip to content

chore: update dependencies#2

Open
reneleonhardt wants to merge 1 commit into
khvzak:mainfrom
reneleonhardt:chore/update-dependencies
Open

chore: update dependencies#2
reneleonhardt wants to merge 1 commit into
khvzak:mainfrom
reneleonhardt:chore/update-dependencies

Conversation

@reneleonhardt

Copy link
Copy Markdown

Chores

  • Update cargo dependencies and github-actions
  • Let dependabot update cargo and github-actions

@reneleonhardt

reneleonhardt commented Nov 25, 2025

Copy link
Copy Markdown
Author

Notes

  • Tests didn't run for me locally, could the integration tests be expanded to use Docker containers like haproxy and jaeger (for example with docker compose or cargo-make)?

https://hub.docker.com/_/haproxy
https://hub.docker.com/r/jaegertracing/jaeger
https://github.com/testcontainers/testcontainers-rs
https://github.com/sagiegurari/cargo-make

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@main
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to use main, could you revert this change or use @v6 (which is much better than a raw hash)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To uphold security best practices, I included all version numbers in the standard comment format to preserve readability. Dependabot will update both, digests and comments.
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idstepsuses
If you insist, I revert everything.
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#example-using-versioned-actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants