Skip to content

Commit 02214b7

Browse files
committed
Publisher messageTypeField can be undefined
1 parent dc62285 commit 02214b7

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

packages/kafka/lib/AbstractKafkaPublisher.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ export abstract class AbstractKafkaPublisher<
4747
for (const { topic, schemas } of this.topicsConfig) {
4848
this.schemaContainers[topic] = new MessageSchemaContainer({
4949
messageSchemas: schemas,
50-
messageDefinitions: [],
5150
messageTypeField: this.options.messageTypeField,
5251
})
5352
}

packages/kafka/lib/AbstractKafkaService.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import type {
2121

2222
export type BaseKafkaOptions = {
2323
kafka: KafkaConfig
24-
messageTypeField: string
24+
messageTypeField?: string
2525
messageIdField?: string
2626
handlerSpy?: HandlerSpy<object> | HandlerSpyParams | boolean
2727
logMessages?: boolean
@@ -59,14 +59,14 @@ export abstract class AbstractKafkaService<
5959
protected resolveMessageType(
6060
message: SupportedMessageValues<TopicsConfig> | null | undefined,
6161
): string | undefined {
62-
// @ts-expect-error
62+
if (!this.options.messageTypeField || !message) return undefined
6363
return message[this.options.messageTypeField]
6464
}
6565

6666
protected resolveMessageId(
6767
message: SupportedMessageValues<TopicsConfig> | null | undefined,
6868
): string | undefined {
69-
// @ts-expect-error
69+
if (!this.options.messageIdField || !message) return undefined
7070
return message[this.options.messageIdField]
7171
}
7272

0 commit comments

Comments
 (0)