Skip to content

Commit bb974b2

Browse files
authored
Solving constructor type issue (#415)
1 parent 5e1e993 commit bb974b2

2 files changed

Lines changed: 9 additions & 4 deletions

File tree

packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ describe('PrometheusMessageErrorCounter', () => {
2121
{
2222
name: 'test_metric',
2323
helpDescription: 'test description',
24-
labelNames: ['errorReason'],
2524
messageVersion: (metadata: ProcessedMessageMetadata<TestMessage>) => {
2625
registeredMessages.push(metadata) // Mocking it to check if value is registered properly
2726
return undefined
@@ -85,7 +84,6 @@ describe('PrometheusMessageErrorCounter', () => {
8584
{
8685
name: 'Test metric',
8786
helpDescription: 'test description',
88-
labelNames: ['errorReason'],
8987
},
9088
promClient,
9189
)
@@ -120,7 +118,6 @@ describe('PrometheusMessageErrorCounter', () => {
120118
{
121119
name: 'Test metric',
122120
helpDescription: 'test description',
123-
labelNames: ['errorReason'],
124121
},
125122
promClient,
126123
)
@@ -168,7 +165,6 @@ describe('PrometheusMessageErrorCounter', () => {
168165
{
169166
name: 'Test metric',
170167
helpDescription: 'test description',
171-
labelNames: ['errorReason'],
172168
messageVersion: (metadata: ProcessedMessageMetadata<TestMessage>) =>
173169
metadata.message?.metadata?.schemaVersion,
174170
},

packages/metrics/lib/prometheus/metrics/message-error/PrometheusMessageErrorCounter.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,19 @@
11
import type { ProcessedMessageMetadata } from '@message-queue-toolkit/core'
2+
import type promClient from 'prom-client'
23
import type { LabelValues } from 'prom-client'
4+
import type { PrometheusMetricParams } from '../../types.ts'
35
import { PrometheusMessageCounter } from './PrometheusMessageCounter.ts'
46

57
export class PrometheusMessageErrorCounter<
68
MessagePayload extends object,
79
> extends PrometheusMessageCounter<MessagePayload, 'errorReason'> {
10+
constructor(
11+
metricParams: Omit<PrometheusMetricParams<MessagePayload, 'errorReason'>, 'labelNames'>,
12+
client: typeof promClient,
13+
) {
14+
super({ ...metricParams, labelNames: ['errorReason'] }, client)
15+
}
16+
817
protected override getLabelValuesForProcessedMessage(
918
metadata: ProcessedMessageMetadata<MessagePayload>,
1019
): LabelValues<'errorReason'> {

0 commit comments

Comments
 (0)