Skip to content

Commit c23e948

Browse files
authored
Topic creation descriptive error (#258)
* Improving topic creation error * Release prepare * Fixing tests * Revert "Fixing tests" This reverts commit f007e50. * Improving error message
1 parent 8089742 commit c23e948

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

packages/sns/lib/utils/snsUtils.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,14 @@ export async function assertTopic(
9696
} catch (error) {
9797
if (!isError(error)) throw error
9898
// To build ARN we need topic name and error should be "topic already exist with different tags"
99-
if (!topicOptions.Name || !isTopicAlreadyExistWithDifferentTagsError(error)) throw error
99+
if (!topicOptions.Name || !isTopicAlreadyExistWithDifferentTagsError(error)) {
100+
throw new InternalError({
101+
message: `${topicOptions.Name} - ${error.message}`,
102+
cause: error,
103+
details: { topicName: topicOptions.Name },
104+
errorCode: 'SNS_CREATE_TOPIC_COMMAND_UNEXPECTED_ERROR',
105+
})
106+
}
100107

101108
topicArn = await buildTopicArn(stsClient, topicOptions.Name)
102109
if (!extraParams?.forceTagUpdate) {
@@ -106,6 +113,7 @@ export async function assertTopic(
106113
throw new InternalError({
107114
message: `${topicOptions.Name} - ${error.message}`,
108115
details: {
116+
topicName: topicOptions.Name,
109117
currentTags: JSON.stringify(currentTags),
110118
newTags: JSON.stringify(topicOptions.Tags),
111119
},

packages/sns/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@message-queue-toolkit/sns",
3-
"version": "21.1.1",
3+
"version": "21.1.2",
44
"private": false,
55
"license": "MIT",
66
"description": "SNS adapter for message-queue-toolkit",

0 commit comments

Comments
 (0)