Skip to content

Commit c4808fb

Browse files
authored
Fixing uncontrolled log size (#262)
* Fixing uncontrolled log size * Test fix * Another test fix
1 parent ce2e611 commit c4808fb

4 files changed

Lines changed: 12 additions & 9 deletions

File tree

packages/amqp/test/consumers/AmqpPermissionConsumer.spec.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import type { AmqpPermissionPublisher } from '../publishers/AmqpPermissionPublis
1515
import { TEST_AMQP_CONFIG } from '../utils/testAmqpConfig.ts'
1616
import type { Dependencies } from '../utils/testContext.ts'
1717
import { SINGLETON_CONFIG, registerDependencies } from '../utils/testContext.ts'
18-
1918
import { AmqpPermissionConsumer } from './AmqpPermissionConsumer.ts'
2019
import type {
2120
PERMISSIONS_ADD_MESSAGE_TYPE,
@@ -111,8 +110,7 @@ describe('AmqpPermissionConsumer', () => {
111110
timestamp: expect.any(String),
112111
},
113112
{
114-
messageId: '1',
115-
processingResult: { status: 'consumed' },
113+
processedMessageMetadata: expect.any(String),
116114
},
117115
])
118116
})

packages/core/lib/queues/AbstractQueueService.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
import { types } from 'node:util'
22

3-
import type { CommonLogger, Either, ErrorReporter, ErrorResolver } from '@lokalise/node-core'
3+
import {
4+
type CommonLogger,
5+
type Either,
6+
type ErrorReporter,
7+
type ErrorResolver,
8+
stringValueSerializer,
9+
} from '@lokalise/node-core'
410
import { resolveGlobalErrorLogObject } from '@lokalise/node-core'
511
import type { CommonEventDefinition } from '@message-queue-toolkit/schemas'
612
import type { ZodSchema, ZodType } from 'zod'
@@ -245,7 +251,7 @@ export abstract class AbstractQueueService<
245251
)
246252
if (debugLoggingEnabled) {
247253
this.logger.debug(
248-
processedMessageMetadata,
254+
{ processedMessageMetadata: stringValueSerializer(processedMessageMetadata) },
249255
`Finished processing message ${processedMessageMetadata.messageId}`,
250256
)
251257
}

packages/core/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@message-queue-toolkit/core",
3-
"version": "21.0.0",
3+
"version": "21.0.1",
44
"private": false,
55
"license": "MIT",
66
"description": "Useful utilities, interfaces and base classes for message queue handling. Supports AMQP and SQS with a common abstraction on top currently",
@@ -29,7 +29,7 @@
2929
"prepublishOnly": "npm run lint && npm run build"
3030
},
3131
"dependencies": {
32-
"@lokalise/node-core": "^13.3.0",
32+
"@lokalise/node-core": "^13.6.0",
3333
"@message-queue-toolkit/schemas": "^6.0.0",
3434
"fast-equals": "^5.0.1",
3535
"json-stream-stringify": "^3.1.6",

packages/sqs/test/consumers/SqsPermissionConsumer.spec.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -318,8 +318,7 @@ describe('SqsPermissionConsumer', () => {
318318
timestamp: expect.any(String),
319319
},
320320
{
321-
messageId: '1',
322-
processingResult: { status: 'consumed' },
321+
processedMessageMetadata: expect.any(String),
323322
},
324323
])
325324
await newConsumer.close()

0 commit comments

Comments
 (0)