Skip to content

Commit dc0c673

Browse files
authored
Log Kafka consumer close errors (#426)
* Log Kafka consumer.close errors * linting * Including resolveErrorLog in error report context
1 parent b33b6ee commit dc0c673

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

packages/kafka/lib/AbstractKafkaConsumer.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { pipeline } from 'node:stream/promises'
33
import { setTimeout } from 'node:timers/promises'
44
import {
55
InternalError,
6+
isError,
67
resolveGlobalErrorLogObject,
78
stringValueSerializer,
89
type TransactionObservabilityManager,
@@ -239,8 +240,14 @@ export abstract class AbstractKafkaConsumer<
239240

240241
try {
241242
await this.consumer.close()
242-
} catch {
243-
// Ignoring errors at this stage
243+
} catch (err) {
244+
// Reporting error but not throwing further
245+
const resolvedErrorLog = resolveGlobalErrorLogObject(err)
246+
this.logger.warn(resolvedErrorLog, 'Error while closing Kafka consumer')
247+
this.errorReporter.report({
248+
error: isError(err) ? err : new Error('Unknown error while closing Kafka consumer'),
249+
context: resolvedErrorLog,
250+
})
244251
}
245252
this.consumer = undefined
246253
}

0 commit comments

Comments
 (0)