types(core): reject the removed messageTypeField option at compile time

`messageTypeField` was removed in core 25.x in favor of
`messageTypeResolver`. Until now the option was simply absent from
`CommonQueueOptions`, but TypeScript's excess-property checks are
weakened across the long `Omit`/`&`/generic chains used by publisher
options (`SnsPublisherManager.newPublisherOptions` etc.), so callers
who hadn't migrated were silently passing a no-op option.

The runtime impact is severe and silent: with payload offloading
enabled, the offload step in `AbstractQueueService` only preserves the
message `type` field on the offloaded body when `messageTypeResolver`
is configured. Callers still on `messageTypeField` end up publishing
SNS messages without `type` in the body, and any subscription with
`FilterPolicyScope: 'MessageBody'` filtering on `type` silently drops
the message before SQS delivery. Production-confirmed against
file-storage-service after its 24.x → 25.x bump.

Type the field as `?: never` with deprecation guidance so it now
fails compilation with a clear error pointing at the migration. Add
type-level guards in core and sns test suites that lock the contract
in place.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: Igor Savin

packages/core/lib/types/queueOptionsTypes.ts

@@ -114,6 +114,16 @@ export type CommonQueueOptions = {
    * }
    */
   messageTypeResolver?: MessageTypeResolverConfig
+  /**
+   * @deprecated Removed in core 25.x. Use `messageTypeResolver: { messageTypePath: '<field>' }`
+   * (or `{ literal: '<type>' }` / `{ resolver: fn }`) instead. See UPGRADING.md.
+   *
+   * Typed as `never` so callers that still pass it get a compile-time error rather than
+   * a silent runtime drop. Notably, leaving this set on a publisher with payload offloading
+   * causes the message `type` field to be stripped from the offloaded SNS body, which then
+   * silently fails any downstream subscription whose FilterPolicy filters on `type`.
+   */
+  messageTypeField?: never
   messageIdField?: string
   messageTimestampField?: string
   messageDeduplicationIdField?: string

packages/core/test/types/queueOptionsTypes.types.spec.ts

@@ -0,0 +1,29 @@
+/**
+ * Type-level tests for `CommonQueueOptions`. These guard against silent removals of legacy
+ * options. The lib historically exposed `messageTypeField`, removed in core 25.x in favor
+ * of `messageTypeResolver`. Callers that still pass the legacy option must get a compile-time
+ * error rather than silently broken runtime behavior (for example: payload offloading drops
+ * the message `type` field, then SNS subscriptions with `FilterPolicyScope: 'MessageBody'`
+ * filter on `type` fail to deliver to SQS).
+ *
+ * Run with: npx tsc --noEmit
+ */
+import { describe, it } from 'vitest'
+import type { CommonQueueOptions } from '../../lib/types/queueOptionsTypes.ts'
+
+describe('CommonQueueOptions — legacy `messageTypeField`', () => {
+  it('rejects passing the removed `messageTypeField` option', () => {
+    const _bad: CommonQueueOptions = {
+      // @ts-expect-error - `messageTypeField` was removed in core 25.x; use `messageTypeResolver` instead
+      messageTypeField: 'type',
+    }
+  })
+
+  it('accepts the supported `messageTypeResolver` shape', () => {
+    const _ok1: CommonQueueOptions = { messageTypeResolver: { messageTypePath: 'type' } }
+    const _ok2: CommonQueueOptions = { messageTypeResolver: { literal: 'order.created' } }
+    const _ok3: CommonQueueOptions = {
+      messageTypeResolver: { resolver: () => 'order.created' },
+    }
+  })
+})

packages/sns/test/SnsPublisherManager.types.spec.ts

@@ -0,0 +1,44 @@
+/**
+ * Type-level guard for `SnsPublisherManager`. Reproduces the call shape that file-storage-service
+ * was using when payload offloading silently broke after the core 24.x → 25.x bump:
+ *
+ * ```ts
+ * new SnsPublisherManager(deps, {
+ *   ...
+ *   newPublisherOptions: {
+ *     messageTypeField: 'type', // <- removed in core 25.x; ignored at runtime, dropped `type` from offloaded SNS body
+ *     ...
+ *   },
+ * })
+ * ```
+ *
+ * This must now fail at compile time.
+ *
+ * Run with: npx tsc --noEmit
+ */
+import { describe, it } from 'vitest'
+import type { SNSPublisherOptions } from '../lib/sns/AbstractSnsPublisher.ts'
+
+type AnyMessage = { type: string }
+
+type NewPublisherOptions = Omit<
+  SNSPublisherOptions<AnyMessage>,
+  'messageSchemas' | 'creationConfig' | 'locatorConfig'
+>
+
+describe('SnsPublisherManager `newPublisherOptions` — legacy `messageTypeField`', () => {
+  it('rejects the removed `messageTypeField` option', () => {
+    const _bad: NewPublisherOptions = {
+      // @ts-expect-error - `messageTypeField` was removed in core 25.x; use `messageTypeResolver` instead
+      messageTypeField: 'type',
+      messageIdField: 'id',
+    }
+  })
+
+  it('accepts `messageTypeResolver`', () => {
+    const _ok: NewPublisherOptions = {
+      messageTypeResolver: { messageTypePath: 'type' },
+      messageIdField: 'id',
+    }
+  })
+})