removed accidental linting fixes

Author: kjamrog

packages/amqp/lib/AbstractAmqpConsumer.ts

@@ -270,6 +270,9 @@ export abstract class AbstractAmqpConsumer<
       return null
     }
     const handler = this.handlerContainer.resolveHandler(processedMessageMetadata.messageType)
+    if (!handler.messageLogFormatter) {
+      return null
+    }
     return handler.messageLogFormatter(processedMessageMetadata.message)
   }
 

packages/core/lib/events/DomainEventEmitter.spec.ts

@@ -204,7 +204,7 @@ describe('DomainEventEmitter', () => {
       expect(emitResult.message).toEqual({
         id: expect.any(String),
         metadata: {
-          correlationId: createdEventPayload.metadata!.correlationId!,
+          correlationId: createdEventPayload.metadata?.correlationId!,
           originatedFrom: 'service',
           producedBy: undefined,
           schemaVersion: '1',

packages/core/lib/queues/HandlerContainer.ts

@@ -55,8 +55,6 @@ export type Prehandler<MessagePayloadSchema extends object, ExecutionContext, Pr
   next: (result: PrehandlerResult) => void,
 ) => void
 
-export const defaultLogFormatter = <MessagePayloadSchema>(message: MessagePayloadSchema) => message
-
 export type HandlerConfigOptions<
   MessagePayloadSchema extends object,
   ExecutionContext,
@@ -98,7 +96,7 @@ export class MessageHandlerConfig<
     PrehandlerOutput,
     BarrierOutput
   >
-  public readonly messageLogFormatter: LogFormatter<MessagePayloadSchema>
+  public readonly messageLogFormatter?: LogFormatter<MessagePayloadSchema>
   public readonly preHandlerBarrier?: BarrierCallback<
     MessagePayloadSchema,
     ExecutionContext,
@@ -126,7 +124,7 @@ export class MessageHandlerConfig<
     this.definition = eventDefinition
     this.messageType = options?.messageType
     this.handler = handler
-    this.messageLogFormatter = options?.messageLogFormatter ?? defaultLogFormatter
+    this.messageLogFormatter = options?.messageLogFormatter
     this.preHandlerBarrier = options?.preHandlerBarrier
     this.preHandlers = options?.preHandlers ?? []
   }

packages/core/test/queues/HandlerContainer.spec.ts

@@ -106,20 +106,6 @@ describe('MessageHandlerConfigBuilder', () => {
       expect(config.messageLogFormatter).toBe(messageLogFormatter)
       expect(config.preHandlers).toEqual([])
     })
-
-    it('should use default log formatter when not provided', () => {
-      const handler = () => Promise.resolve({ result: 'success' as const })
-
-      const config = new MessageHandlerConfig(USER_MESSAGE_SCHEMA, handler)
-
-      const testMessage: UserMessage = {
-        type: 'user.created',
-        userId: '123',
-        email: 'test@example.com',
-      }
-
-      expect(config.messageLogFormatter(testMessage)).toEqual(testMessage)
-    })
   })
 })
 

packages/gcp-pubsub/lib/pubsub/AbstractPubSubConsumer.ts

@@ -869,6 +869,9 @@ export abstract class AbstractPubSubConsumer<
       return null
     }
     const handler = this.handlerContainer.resolveHandler(processedMessageMetadata.messageType)
+    if (!handler.messageLogFormatter) {
+      return null
+    }
     return handler.messageLogFormatter(processedMessageMetadata.message)
   }
 

packages/sns/lib/utils/snsInitter.ts

@@ -111,7 +111,7 @@ export async function initSnsSqs(
     queueName = splitUrl[splitUrl.length - 1]!
   } else {
     // biome-ignore lint/style/noNonNullAssertion: It's ok
-    queueName = creationConfig!.queue.QueueName!
+    queueName = creationConfig?.queue.QueueName!
   }
 
   return {

packages/sns/test/publishers/SnsPermissionPublisher.multiStorePayloadOffloading.spec.ts

@@ -132,7 +132,7 @@ describe('SnsPermissionPublisher - multi-store payload offloading', () => {
       // Check that the published message's body is a pointer to the offloaded payload
       expect(receivedSnsMessages.length).toBe(1)
       const snsMessageBodyParseResult = SNS_MESSAGE_BODY_SCHEMA.safeParse(
-        JSON.parse(receivedSnsMessages[0].Body!),
+        JSON.parse(receivedSnsMessages[0]!.Body!),
       )
       expect(snsMessageBodyParseResult.success).toBe(true)
 

packages/sns/test/publishers/SnsPermissionPublisher.payloadOffloading.spec.ts

@@ -130,7 +130,7 @@ describe('SnsPermissionPublisher - single-store payload offloading', () => {
       // Check that the published message's body is a pointer to the offloaded payload.
       expect(receivedSnsMessages.length).toBe(1)
       const snsMessageBodyParseResult = SNS_MESSAGE_BODY_SCHEMA.safeParse(
-        JSON.parse(receivedSnsMessages[0].Body!),
+        JSON.parse(receivedSnsMessages[0]!.Body!),
       )
       expect(snsMessageBodyParseResult.success).toBe(true)
 

packages/sns/test/utils/snsSubscriber.spec.ts

@@ -144,7 +144,7 @@ describe('snsSubscriber', () => {
 
       const subscriptionAttributes = await getSubscriptionAttributes(
         snsClient,
-        updatedSubscription.SubscriptionArn!,
+        updatedSubscription!.SubscriptionArn!,
       )
       expect(subscriptionAttributes).toEqual({
         result: {

packages/sqs/lib/fakes/TestSqsPublisher.spec.ts

@@ -64,7 +64,7 @@ describe('TestSqsPublisher', () => {
       consumer.stop()
 
       expect(receivedMessages).toHaveLength(1)
-      const body = JSON.parse(receivedMessages[0]!.Body!)
+      const body = JSON.parse(receivedMessages[0]?.Body!)
       expect(body).toEqual({
         totally: 'arbitrary',
         data: { nested: true },
@@ -95,7 +95,7 @@ describe('TestSqsPublisher', () => {
       consumer.stop()
 
       expect(receivedMessages).toHaveLength(1)
-      const body = JSON.parse(receivedMessages[0]!.Body!)
+      const body = JSON.parse(receivedMessages[0]?.Body!)
       expect(body).toEqual({ incomplete: 'message' })
     })
 
@@ -133,7 +133,7 @@ describe('TestSqsPublisher', () => {
       consumer.stop()
 
       expect(receivedMessages).toHaveLength(1)
-      const body = JSON.parse(receivedMessages[0]!.Body!)
+      const body = JSON.parse(receivedMessages[0]?.Body!)
       expect(body).toEqual(complexMessage)
     })
   })
@@ -160,7 +160,7 @@ describe('TestSqsPublisher', () => {
       consumer.stop()
 
       expect(receivedMessages).toHaveLength(1)
-      const body = JSON.parse(receivedMessages[0]!.Body!)
+      const body = JSON.parse(receivedMessages[0]?.Body!)
       expect(body).toEqual({ test: 'queueName' })
     })
   })
@@ -193,7 +193,7 @@ describe('TestSqsPublisher', () => {
       sqsConsumer.stop()
 
       expect(receivedMessages).toHaveLength(1)
-      const body = JSON.parse(receivedMessages[0]!.Body!)
+      const body = JSON.parse(receivedMessages[0]?.Body!)
       expect(body).toEqual({ test: 'consumer' })
 
       await consumer.close()
@@ -240,7 +240,7 @@ describe('TestSqsPublisher', () => {
       consumer.stop()
 
       expect(receivedMessages).toHaveLength(1)
-      const body = JSON.parse(receivedMessages[0]!.Body!)
+      const body = JSON.parse(receivedMessages[0]?.Body!)
       expect(body).toEqual({ test: 'publisher' })
     })
 
@@ -292,7 +292,7 @@ describe('TestSqsPublisher', () => {
       consumer.stop()
 
       expect(receivedMessages).toHaveLength(1)
-      const body = JSON.parse(receivedMessages[0]!.Body!)
+      const body = JSON.parse(receivedMessages[0]?.Body!)
       expect(body).toEqual({ test: 'fifo-message' })
     })
   })