Skip to content

Chore: TECH-894 kafka bootstrap#260

Merged
CarlosGamero merged 23 commits intomainfrom
chore/TECH-894_kafka_bootstrap
May 2, 2025
Merged

Chore: TECH-894 kafka bootstrap#260
CarlosGamero merged 23 commits intomainfrom
chore/TECH-894_kafka_bootstrap

Conversation

@CarlosGamero
Copy link
Copy Markdown
Collaborator

@CarlosGamero CarlosGamero commented Apr 28, 2025

No description provided.

@CarlosGamero CarlosGamero self-assigned this Apr 28, 2025
Comment thread packages/kafka/package.json Outdated
Comment thread packages/kafka/package.json Outdated
Comment thread packages/kafka/lib/test.spec.ts Outdated
@CarlosGamero
Copy link
Copy Markdown
Collaborator Author

Finally green! 🚀
I will test https://blog.platformatic.dev/why-we-created-another-kafka-client-for-nodejs?showSharer=true in a follow-up PR

@CarlosGamero CarlosGamero marked this pull request as ready for review April 30, 2025 17:54
@CarlosGamero CarlosGamero requested a review from kibertoad April 30, 2025 17:54
Comment thread docker-compose.yml
restart: on-failure

kafka:
image: apache/kafka:latest
Copy link
Copy Markdown
Owner

@kibertoad kibertoad Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's generally recommended to pin infra dependencies to specific versions to ensure runs are deterministic. let's use the latest one for now (explicitly stated), and adjust after we have actual infra

@CarlosGamero CarlosGamero merged commit d8f09d4 into main May 2, 2025
6 checks passed
@CarlosGamero CarlosGamero deleted the chore/TECH-894_kafka_bootstrap branch May 2, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants