Skip to content

Chore: ESM migration#261

Merged
CarlosGamero merged 30 commits intomainfrom
chore/esm_migration
Apr 29, 2025
Merged

Chore: ESM migration#261
CarlosGamero merged 30 commits intomainfrom
chore/esm_migration

Conversation

@CarlosGamero
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread packages/amqp/package.json Outdated
"devDependencies": {
"@biomejs/biome": "1.9.4",
"@kibertoad/biome-config": "^1.2.1",
"@lokalise/tsconfig": "^1.3.0",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should switch to lokalise biome config as well, any thoughts?

Copy link
Copy Markdown
Collaborator Author

@CarlosGamero CarlosGamero Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same question, and was going to ask you tomorrow 😓 (today we had a massive connection and electricity issue in Spain, service is starting to recover just now).

If you agree with using lokalise/biome, I would make it independently, those changes should not require a release

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think it would be a good fit

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! adding it to my todo list :D

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the and I had to it in this same PR ... 😓 we need .js/.ts imports in ESM and migration to lokalise/biome is easier than reverting tsconfig one

Copy link
Copy Markdown
Collaborator Author

@CarlosGamero CarlosGamero Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the huge PR 🙏 please ignore all lib and test changes, they are only about lint fixes and imports.

important changes are package.json tsconfig and vitest.config.ts

@CarlosGamero CarlosGamero marked this pull request as ready for review April 28, 2025 19:14
@CarlosGamero CarlosGamero merged commit ce2e611 into main Apr 29, 2025
6 checks passed
@CarlosGamero CarlosGamero deleted the chore/esm_migration branch April 29, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants