Merge pull request #2046 from kili-technology/feature/lab-4399-aau-when-i-export-from-the-ui-or-the-sdk-there-is-no-double

fix(LAB-4399): fix to ensure if there is already an extension to not add a second one

Author: stchabi

src/kili/use_cases/asset/media_downloader.py

@@ -1,5 +1,5 @@
 """Helpers for the asset queries."""
-
+import mimetypes
 import warnings
 from collections.abc import Callable
 from concurrent.futures import ThreadPoolExecutor
@@ -209,8 +209,12 @@ def get_download_path(
 ) -> Path:
     """Build the path to download a file the file in local."""
     extension = get_file_extension_from_headers(url, http_client)
-    filename = external_id
-    if extension is not None and not filename.endswith(extension):
+    filename = str(external_id)
+    current_suffix = Path(filename).suffix.lower()
+    has_known_extension = (
+        current_suffix != "" and mimetypes.types_map.get(current_suffix) is not None
+    )
+    if extension is not None and not has_known_extension:
         filename = filename + extension
     local_dir_path = local_dir_path / filename
     return local_dir_path.resolve()

tests/unit/test_media_downloader.py

@@ -6,7 +6,8 @@
 import pytest
 
 from kili.adapters.http_client import HttpClient
-from kili.use_cases.asset.media_downloader import MediaDownloader
+from kili.domain.asset import AssetExternalId
+from kili.use_cases.asset.media_downloader import MediaDownloader, get_download_path
 from kili.utils.tempfile import TemporaryDirectory
 
 
@@ -198,3 +199,39 @@ def test_download_media_jsoncontent_none(mocker, content, jsoncontent, should_ca
             http_client.get.assert_called()
         else:
             http_client.get.assert_not_called()
+
+
+def test_get_download_path_no_double_extension(mocker):
+    mocker.patch(
+        "kili.use_cases.asset.media_downloader.get_file_extension_from_headers",
+        return_value=".jpg",
+    )
+    http_client = mocker.MagicMock(spec=HttpClient)
+    path = get_download_path(
+        "https://example.com/img", AssetExternalId("photo.jpeg"), Path("/tmp"), http_client
+    )
+    assert path.name == "photo.jpeg"  # not "photo.jpeg.jpg"
+
+
+def test_get_download_path_with_valid_extension(mocker):
+    mocker.patch(
+        "kili.use_cases.asset.media_downloader.get_file_extension_from_headers",
+        return_value=".jpg",
+    )
+    http_client = mocker.MagicMock(spec=HttpClient)
+    path = get_download_path(
+        "https://example.com/img", AssetExternalId("photo.aaa"), Path("/tmp"), http_client
+    )
+    assert path.name == "photo.aaa.jpg"  # not "photo.aaa"
+
+
+def test_get_download_path_with_extension(mocker):
+    mocker.patch(
+        "kili.use_cases.asset.media_downloader.get_file_extension_from_headers",
+        return_value=".jpg",
+    )
+    http_client = mocker.MagicMock(spec=HttpClient)
+    path = get_download_path(
+        "https://example.com/img", AssetExternalId("photo"), Path("/tmp"), http_client
+    )
+    assert path.name == "photo.jpg"  # not "photo"