Skip to content

Commit e6b6bfb

Browse files
authored
Merge pull request #1973 from kili-technology/feature/lab-3992-aau-when-i-cant-import-asset-with-invalid-json_metadatas
fix(LAB-3992): fix to ensure the json_metadatas is correct
2 parents 8026ec9 + 1b9a647 commit e6b6bfb

File tree

1 file changed

+6
-1
lines changed
  • src/kili/services/asset_import

1 file changed

+6
-1
lines changed

src/kili/services/asset_import/base.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,12 @@ def stringify_metadata(asset: AssetLike) -> AssetLike:
165165
"""Stringify the metadata."""
166166
json_metadata = asset.get("json_metadata", {})
167167
if not isinstance(json_metadata, str):
168-
json_metadata = dumps(json_metadata)
168+
try:
169+
json_metadata = dumps(json_metadata, allow_nan=False)
170+
except (ValueError, TypeError) as e:
171+
raise ValueError(
172+
f"Invalid json_metadata: cannot be serialized to valid JSON ({e})"
173+
) from e
169174
return {**asset, "json_metadata": json_metadata}
170175

171176
@staticmethod

0 commit comments

Comments
 (0)