Clarify internal heartbeat conversion#2
Closed
kim-em wants to merge 1 commit into
Closed
Conversation
kim-em
added a commit
that referenced
this pull request
Mar 4, 2026
- Use parallel `for sArg in sourceArgs, eArg in expectedArgs` (#2) - Use `repeat do` instead of fuel-bounded loop (#3) - Use modern range syntax `*...n` and `n...m` (leanprover-community#9, leanprover-community#10) - Use `fieldInfo[i]?` instead of bounds check (leanprover-community#11) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kim-em
added a commit
that referenced
this pull request
Apr 23, 2026
Addresses PR review comments: - :98 - delete discreteTopology_fiber; downstream users call .discreteTopology_fiber on isCoveringMap directly (per Kim's ruling on pushback #2) - :203 - collapse the 2-step calc (simp + simpa) into a single `rw [← hΓ_eq_lift]; simpa ...` block - :233 - collapse the 3-step calc in h_end to a single `rw [...]; exact p.target` line - :278 - keep the calc in skeletal form per pushback #3 ruling, but tighten from 6 steps to 5 and add a prose header explaining the α⁻¹·α insertion trick Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sleep_heartbeatsmultiplies user input by 1000 to access the internal heartbeat counter.Testing
lake build Mathlib.Util.SleepHeartbeatshttps://chatgpt.com/codex/tasks/task_e_68a003a948f483219633825547b190e0