forge-v2: perf(sandbox): optimize Windows sandbox initialization via native ACL application#3
Open
kimjune01 wants to merge 1 commit intoc-test-25077from
Open
forge-v2: perf(sandbox): optimize Windows sandbox initialization via native ACL application#3kimjune01 wants to merge 1 commit intoc-test-25077from
kimjune01 wants to merge 1 commit intoc-test-25077from
Conversation
Blind-blind winner: codex Complexity gate: delta=0 Reviewer: approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forge-v2 refactored version of google-gemini/gemini-cli#25077
Original PR
perf(sandbox): optimize Windows sandbox initialization via native ACL application
Summary
This PR optimizes the Windows sandbox initialization performance by offloading file system ACL modifications from Node.js to the native C# helper (
GeminiSandbox.exe). This eliminates the overhead of spawning multipleicacls.exeprocesses.Details
GeminiSandbox.csto apply ACLs natively using .NET'sFileSystemSecurityand P/Invoke (SetNamedSecurityInfo).WindowsSandboxManager.tsnow aggregates allowed and forbidden paths into temporary manifest files, which are passed to the helper via--allowed-manifestand--forbidden-manifestflags.Related Issues
N/A
How to Validate
Execute the unit and integration tests on a Windows environment:
Pre-Merge Checklist
Forge-v2 pipeline results
Refactoring claims applied
What is this?
This diff shows the output of a forge-wrapped LLM refactoring pipeline applied to PR google-gemini#25077's code at the point where tests first passed (
C_test). The question: can an autonomous pipeline improve the implementation before human review?Pipeline: goal-anchored volley → adversarial hunt-spec → blind-blind implementation (Opus 4.6 + Codex GPT-5.4, smaller-churn wins) → hunt-code with full build+tests → Gemini 3.1 Pro reviewer-loop → complexity gate (δ=0.05).
Experiment: refactor-equivalence v2 — Does an LLM refactoring pass help or hurt brownfield PRs?