Skip to content

forge-v2: perf(sandbox): optimize Windows sandbox initialization via native ACL application #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kimjune01 wants to merge 1 commit into from
Closed

forge-v2: perf(sandbox): optimize Windows sandbox initialization via native ACL application #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 52 additions & 40 deletions packages/core/src/sandbox/windows/GeminiSandbox.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ struct TOKEN_MANDATORY_LABEL {
private const uint DISABLE_MAX_PRIVILEGE = 0x1;
private const int SE_FILE_OBJECT = 1;
private const uint LABEL_SECURITY_INFORMATION = 0x00000010;
private const string LowIntegritySid = "S-1-16-4096";

static int Main(string[] args) {
if (args.Length < 3) {
Expand Down Expand Up @@ -251,9 +252,8 @@ static int Main(string[] args) {
}

// 2. Lower Integrity Level to Low
// S-1-16-4096 is the SID for "Low Mandatory Level"
IntPtr lowIntegritySid = IntPtr.Zero;
if (ConvertStringSidToSid("S-1-16-4096", out lowIntegritySid)) {
if (ConvertStringSidToSid(LowIntegritySid, out lowIntegritySid)) {
TOKEN_MANDATORY_LABEL tml = new TOKEN_MANDATORY_LABEL();
tml.Label.Sid = lowIntegritySid;
tml.Label.Attributes = SE_GROUP_INTEGRITY;
Expand Down Expand Up @@ -431,60 +431,72 @@ private static void ParseManifest(string manifestPath, HashSet<string> paths) {
}

private static void ApplyBulkAcls(HashSet<string> allowedPaths, HashSet<string> forbiddenPaths) {
SecurityIdentifier lowSid = new SecurityIdentifier("S-1-16-4096");
SecurityIdentifier lowSid = new SecurityIdentifier(LowIntegritySid);

foreach (string path in forbiddenPaths) {
try {
if (File.Exists(path)) {
FileSecurity fs = File.GetAccessControl(path);
fs.AddAccessRule(new FileSystemAccessRule(lowSid, FileSystemRights.FullControl, AccessControlType.Deny));
File.SetAccessControl(path, fs);
} else if (Directory.Exists(path)) {
DirectorySecurity ds = Directory.GetAccessControl(path);
ds.AddAccessRule(new FileSystemAccessRule(lowSid, FileSystemRights.FullControl, InheritanceFlags.ContainerInherit | InheritanceFlags.ObjectInherit, PropagationFlags.None, AccessControlType.Deny));
Directory.SetAccessControl(path, ds);
}
ApplyDenyAcl(path, lowSid);
} catch (Exception e) {
Console.Error.WriteLine("Warning: Failed to apply deny ACL to " + path + ": " + e.Message);
}
}

foreach (string path in allowedPaths) {
try {
bool isDir = Directory.Exists(path);
if (isDir) {
DirectorySecurity ds = Directory.GetAccessControl(path);
ds.AddAccessRule(new FileSystemAccessRule(lowSid, FileSystemRights.Modify, InheritanceFlags.ContainerInherit | InheritanceFlags.ObjectInherit, PropagationFlags.None, AccessControlType.Allow));
Directory.SetAccessControl(path, ds);
} else if (File.Exists(path)) {
FileSecurity fs = File.GetAccessControl(path);
fs.AddAccessRule(new FileSystemAccessRule(lowSid, FileSystemRights.Modify, AccessControlType.Allow));
File.SetAccessControl(path, fs);
} else {
continue;
}

string sddl = isDir ? "S:(ML;OICI;NW;;;LW)" : "S:(ML;;NW;;;LW)";
IntPtr pSD = IntPtr.Zero;
uint sdSize = 0;
if (ConvertStringSecurityDescriptorToSecurityDescriptor(sddl, 1, out pSD, out sdSize)) {
bool saclPresent = false;
IntPtr pSacl = IntPtr.Zero;
bool saclDefaulted = false;
if (GetSecurityDescriptorSacl(pSD, out saclPresent, out pSacl, out saclDefaulted) && saclPresent) {
uint result = SetNamedSecurityInfo(path, SE_FILE_OBJECT, LABEL_SECURITY_INFORMATION, IntPtr.Zero, IntPtr.Zero, IntPtr.Zero, pSacl);
if (result != 0) {
Console.Error.WriteLine("Warning: SetNamedSecurityInfo failed for " + path + " with error " + result);
}
}
LocalFree(pSD);
}
ApplyAllowAcl(path, lowSid);
} catch (Exception e) {
Console.Error.WriteLine("Warning: Failed to apply allow ACL to " + path + ": " + e.Message);
}
}
}

private static void ApplyDenyAcl(string path, SecurityIdentifier lowSid) {
if (File.Exists(path)) {
FileSecurity fs = File.GetAccessControl(path);
fs.AddAccessRule(new FileSystemAccessRule(lowSid, FileSystemRights.FullControl, AccessControlType.Deny));
File.SetAccessControl(path, fs);
} else if (Directory.Exists(path)) {
DirectorySecurity ds = Directory.GetAccessControl(path);
ds.AddAccessRule(new FileSystemAccessRule(lowSid, FileSystemRights.FullControl, InheritanceFlags.ContainerInherit | InheritanceFlags.ObjectInherit, PropagationFlags.None, AccessControlType.Deny));
Directory.SetAccessControl(path, ds);
}
}

private static void ApplyAllowAcl(string path, SecurityIdentifier lowSid) {
bool isDirectory = Directory.Exists(path);
if (isDirectory) {
DirectorySecurity ds = Directory.GetAccessControl(path);
ds.AddAccessRule(new FileSystemAccessRule(lowSid, FileSystemRights.Modify, InheritanceFlags.ContainerInherit | InheritanceFlags.ObjectInherit, PropagationFlags.None, AccessControlType.Allow));
Directory.SetAccessControl(path, ds);
} else if (File.Exists(path)) {
FileSecurity fs = File.GetAccessControl(path);
fs.AddAccessRule(new FileSystemAccessRule(lowSid, FileSystemRights.Modify, AccessControlType.Allow));
File.SetAccessControl(path, fs);
} else {
return;
}

ApplyLowIntegrityLabel(path, isDirectory);
}

private static void ApplyLowIntegrityLabel(string path, bool isDirectory) {
string sddl = isDirectory ? "S:(ML;OICI;NW;;;LW)" : "S:(ML;;NW;;;LW)";
IntPtr pSD = IntPtr.Zero;
uint sdSize = 0;
if (ConvertStringSecurityDescriptorToSecurityDescriptor(sddl, 1, out pSD, out sdSize)) {
bool saclPresent = false;
IntPtr pSacl = IntPtr.Zero;
bool saclDefaulted = false;
if (GetSecurityDescriptorSacl(pSD, out saclPresent, out pSacl, out saclDefaulted) && saclPresent) {
uint result = SetNamedSecurityInfo(path, SE_FILE_OBJECT, LABEL_SECURITY_INFORMATION, IntPtr.Zero, IntPtr.Zero, IntPtr.Zero, pSacl);
if (result != 0) {
Console.Error.WriteLine("Warning: SetNamedSecurityInfo failed for " + path + " with error " + result);
}
}
LocalFree(pSD);
}
}

private static int RunInImpersonation(IntPtr hToken, Func<int> action) {
if (!ImpersonateLoggedOnUser(hToken)) {
Console.Error.WriteLine("Error: ImpersonateLoggedOnUser failed (" + Marshal.GetLastWin32Error() + ")");
Expand Down
18 changes: 9 additions & 9 deletions packages/core/src/sandbox/windows/WindowsSandboxManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,17 +413,17 @@ export class WindowsSandboxManager implements SandboxManager {
path.join(os.tmpdir(), 'gemini-cli-sandbox-'),
);

const forbiddenManifestPath = path.join(tempDir, 'forbidden.txt');
fs.writeFileSync(
forbiddenManifestPath,
Array.from(forbiddenManifest).join('\n'),
);
const writeManifest = (fileName: string, paths: Iterable<string>) => {
const manifestPath = path.join(tempDir, fileName);
fs.writeFileSync(manifestPath, Array.from(paths).join('\n'));
return manifestPath;
};

const allowedManifestPath = path.join(tempDir, 'allowed.txt');
fs.writeFileSync(
allowedManifestPath,
Array.from(allowedManifest).join('\n'),
const forbiddenManifestPath = writeManifest(
'forbidden.txt',
forbiddenManifest,
);
const allowedManifestPath = writeManifest('allowed.txt', allowedManifest);

// 6. Construct the helper command
const program = this.helperPath;
Expand Down
Loading