Skip to content

Fix 13 pytest warnings by registering timeout marker and removing inv… #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kimocoder merged 1 commit into from
Mar 6, 2026
Merged

Fix 13 pytest warnings by registering timeout marker and removing inv… #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ python_files = ["test_*.py"]
python_classes = ["Test*"]
python_functions = ["test_*"]
addopts = "-v --tb=short"
timeout = 30
markers = [
"timeout(seconds): set a timeout for the test (requires pytest-timeout)",
]

Copilot AI Mar 6, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the global timeout = 30 ini option changes test behavior: any test file that does not set @pytest.mark.timeout (most files in tests/ currently don’t) will no longer have a safety timeout and could hang indefinitely. If the intent is to keep a default timeout while eliminating warnings, consider enforcing/ensuring pytest-timeout is installed for test runs (e.g., via required_plugins) and keep the ini option, or add a global timeout mark via tests/conftest.py/common pytest configuration so all tests remain bounded.

Suggested change
]
]
timeout = 30
required_plugins = ["pytest-timeout"]

Copilot uses AI. Check for mistakes.

[build-system]
requires = ["poetry-core"]
Expand Down
Loading