Skip to content

Potential fix for code scanning alert no. 16: Uncontrolled data used in path expression #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kimocoder merged 1 commit into from
Jun 22, 2026
Merged

Potential fix for code scanning alert no. 16: Uncontrolled data used in path expression #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions wifite/attack/portal/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,10 @@
try:
# Remove /static/ prefix and ensure a relative path
file_path = path[8:].lstrip('/\\') # Remove '/static/' and any leading separators
if not file_path:
self._send_error_response(404, 'Not Found')
return

filename = os.path.basename(file_path)

# Try to get cached static file from server instance
Expand All @@ -248,6 +252,17 @@
static_dir = os.path.realpath(os.path.join(portal_dir, 'static'))
# Build and normalize full path to requested file
full_path = os.path.realpath(os.path.join(static_dir, file_path))

# Enforce that the requested file stays under static_dir
Comment thread
kimocoder marked this conversation as resolved.
if os.path.commonpath([static_dir, full_path]) != static_dir:
log_warning('Portal', f'Blocked path traversal attempt: {path}')
self._send_error_response(403, 'Forbidden')
return

if not os.path.isfile(full_path):

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
Loading
.
self._send_error_response(404, 'Not Found')
return
full_path = os.path.realpath(os.path.join(static_dir, file_path))

# Security check: ensure file is within static directory
if os.path.commonpath([static_dir, full_path]) != static_dir:
Expand Down
Loading