-
-
Notifications
You must be signed in to change notification settings - Fork 80
Improve type coverage by generating types #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
robertherber
merged 17 commits into
kingstinct:master
from
ziahamza:generate-healthkit-types
Apr 8, 2026
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c8492e8
feat(types): improve type coverage by generating types
ziahamza 7f567f0
chore: nuke typedMetadata and type existing metadata instead
ziahamza 0cc4a5d
fix(types): tighten metadata typing surface
ziahamza c04f1ae
feat: nuked metadataX and improve types
ziahamza c12cb27
chore: update changeset
ziahamza 1f4eedd
feat: add healthkit contract harness
ziahamza 05d8492
feat: add zod support and more tests
ziahamza 30f4edd
refactor: scope healthkit contracts to example app
ziahamza 603ade2
fix: tap applesimutils in CI
ziahamza 8a81cc6
fix: let contract runner boot simulator in CI
ziahamza 697cfbb
Merge branch 'master' into generate-healthkit-types
robertherber a98cba4
Merge branch 'master' into generate-healthkit-types
robertherber 94cb26b
fix: filter ios CI and tighten typed bindings
ziahamza 035d621
fix: filter ios CI and tighten typed bindings
ziahamza f72a53b
fix: restore expo prebuild in ios CI
ziahamza 281663c
fix: secure preview workflow and widen ios build filter
ziahamza 56e6e4c
Merge branch 'master' of https://github.com/kingstinct/react-native-h…
ziahamza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| --- | ||
| '@kingstinct/react-native-healthkit': major | ||
| --- | ||
|
|
||
| Make typed `metadata` the canonical metadata API and generate more of the HealthKit type surface from Apple’s SDK. | ||
|
|
||
| This release introduces generated identifier/value/unit metadata, typed metadata payloads on returned models, generic quantity sample typing, and SDK-backed schema verification to keep the surfaced API aligned with the pinned Xcode HealthKit SDK. | ||
|
|
||
| Breaking changes: | ||
|
|
||
| - Remove the legacy flattened `metadataX` fields from returned models. | ||
| - Make `metadata` the single canonical metadata surface. | ||
|
|
||
| Migration examples: | ||
|
|
||
| - `sample.metadataExternalUUID` -> `sample.metadata.HKExternalUUID` | ||
| - `sample.metadataWeatherCondition` -> `sample.metadata.HKWeatherCondition` | ||
| - `workout.metadataAverageMETs` -> `workout.metadata.HKAverageMETs` | ||
| - `categorySample.metadataMenstrualCycleStart` -> `categorySample.metadata.HKMenstrualCycleStart` | ||
|
|
||
| This is intended to make the library easier to extend over time: Apple SDK metadata flows into the generated schema and typed `metadata` surface with much less hand-maintained code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.