Add skills, clean codegen#339
Merged
Merged
Conversation
|
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a set of “skills”/agent reference docs (Expo + React Native best practices) and tweaks local tooling/scripts to keep generated Nitrogen output clean and easier to work with in-editor.
Changes:
- Introduces skills lock + Claude/agent skill wiring under
.agents/and.claude/ - Adds extensive React Native/Expo reference docs (animations, gestures, audio, multithreading, on-device AI, etc.)
- Updates
codegenscript to wipe generated Nitrogen output before re-running codegen; updates VS Code search excludes
Reviewed changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| skills-lock.json | Adds a lock file pinning skill sources + hashes |
| packages/react-native-healthkit/ReactNativeHealthkit.podspec | Minor formatting change near Nitrogen autolinking/workaround comments |
| package.json | Updates codegen workflow to delete generated output before regenerating |
| .vscode/settings.json | Excludes agent/skill directories and common generated folders from search |
| .claude/skills/upgrading-expo | Adds pointer file for Claude skill |
| .claude/skills/react-native-best-practices | Adds pointer file for Claude skill |
| .claude/skills/expo-dev-client | Adds pointer file for Claude skill |
| .claude/skills/expo-deployment | Adds pointer file for Claude skill |
| .claude/settings.json | Enables selected Claude plugins |
| .agents/skills/upgrading-expo/references/react-compiler.md | Adds upgrade reference doc |
| .agents/skills/upgrading-expo/references/react-19.md | Adds upgrade reference doc |
| .agents/skills/upgrading-expo/references/new-architecture.md | Adds upgrade reference doc |
| .agents/skills/upgrading-expo/references/native-tabs.md | Adds upgrade reference doc |
| .agents/skills/upgrading-expo/references/expo-av-to-video.md | Adds upgrade reference doc |
| .agents/skills/upgrading-expo/references/expo-av-to-audio.md | Adds upgrade reference doc |
| .agents/skills/upgrading-expo/SKILL.md | Adds “upgrading-expo” skill entry point |
| .agents/skills/react-native-best-practices/references/svg/when-to-use.md | Adds SVG guidance reference |
| .agents/skills/react-native-best-practices/references/svg/svg.md | Adds SVG usage reference |
| .agents/skills/react-native-best-practices/references/svg/SKILL.md | Adds SVG sub-skill index |
| .agents/skills/react-native-best-practices/references/on-device-ai/speech.md | Adds on-device AI speech reference |
| .agents/skills/react-native-best-practices/references/on-device-ai/setup.md | Adds on-device AI setup reference |
| .agents/skills/react-native-best-practices/references/on-device-ai/SKILL.md | Adds on-device AI sub-skill index |
| .agents/skills/react-native-best-practices/references/multithreading/threading-api.md | Adds multithreading API reference |
| .agents/skills/react-native-best-practices/references/multithreading/shared-memory.md | Adds multithreading shared-memory reference |
| .agents/skills/react-native-best-practices/references/multithreading/setup-and-advanced.md | Adds multithreading setup/advanced reference |
| .agents/skills/react-native-best-practices/references/multithreading/SKILL.md | Adds multithreading sub-skill index |
| .agents/skills/react-native-best-practices/references/gestures/testing.md | Adds gesture testing reference |
| .agents/skills/react-native-best-practices/references/gestures/tap-handling.md | Adds tap patterns reference |
| .agents/skills/react-native-best-practices/references/gestures/swipeable-and-drawer.md | Adds swipeable/drawer reference |
| .agents/skills/react-native-best-practices/references/gestures/gestures.md | Adds gestures overview reference |
| .agents/skills/react-native-best-practices/references/gestures/gesture-composition.md | Adds gesture composition reference |
| .agents/skills/react-native-best-practices/references/gestures/continuous-gestures.md | Adds continuous gestures reference |
| .agents/skills/react-native-best-practices/references/gestures/SKILL.md | Adds gestures sub-skill index |
| .agents/skills/react-native-best-practices/references/audio/worklets.md | Adds audio worklets reference |
| .agents/skills/react-native-best-practices/references/audio/recording.md | Adds audio recording reference |
| .agents/skills/react-native-best-practices/references/audio/playback.md | Adds audio playback reference |
| .agents/skills/react-native-best-practices/references/audio/effects-and-analysis.md | Adds audio effects/analysis reference |
| .agents/skills/react-native-best-practices/references/audio/audio.md | Adds audio core concepts reference |
| .agents/skills/react-native-best-practices/references/audio/SKILL.md | Adds audio sub-skill index |
| .agents/skills/react-native-best-practices/references/animations/svg-animations.md | Adds SVG animation reference |
| .agents/skills/react-native-best-practices/references/animations/scroll-and-events.md | Adds scroll/events animation reference |
| .agents/skills/react-native-best-practices/references/animations/layout-animations.md | Adds layout animations reference |
| .agents/skills/react-native-best-practices/references/animations/canvas-atlas.md | Adds Skia Atlas reference |
| .agents/skills/react-native-best-practices/references/animations/animations.md | Adds animations overview reference |
| .agents/skills/react-native-best-practices/references/animations/animations-performance.md | Adds animations perf/accessibility reference |
| .agents/skills/react-native-best-practices/references/animations/animation-functions.md | Adds Reanimated core hooks/functions reference |
| .agents/skills/react-native-best-practices/references/animations/SKILL.md | Adds animations sub-skill index |
| .agents/skills/react-native-best-practices/SKILL.md | Adds root “react-native-best-practices” skill index |
| .agents/skills/react-native-best-practices/README.md | Adds documentation for the skill pack |
| .agents/skills/expo-dev-client/SKILL.md | Adds Expo dev-client skill entry point |
| .agents/skills/expo-deployment/references/workflows.md | Adds EAS workflows reference |
| .agents/skills/expo-deployment/references/testflight.md | Adds TestFlight reference |
| .agents/skills/expo-deployment/references/play-store.md | Adds Play Store reference |
| .agents/skills/expo-deployment/references/ios-app-store.md | Adds iOS App Store reference |
| .agents/skills/expo-deployment/SKILL.md | Adds Expo deployment skill entry point |
Comments suppressed due to low confidence (4)
package.json:1
rm -rfmakes thecodegenscript Unix-shell dependent and will fail for contributors running on Windows (and some CI environments). Consider replacing the deletion step with a cross-platform command (e.g.,rimraf, or a Node/Bun one-liner usingfs.rmSync(..., { recursive: true, force: true })).
package.json:1- This post-processing step can silently succeed even when it doesn’t modify anything (e.g., codegen template changes, glob matches no files), leaving the later
pod installfailure harder to diagnose. Consider adding an explicit check that at least one file was matched and at least one substitution occurred (and otherwise exit non-zero with a clear message).
.vscode/settings.json:1 - The
.claude/skillspattern may not exclude nested files consistently across VS Code glob matching (it’s safer to exclude the directory contents explicitly). Consider changing it to.claude/skills/**(and optionally using**/.claude/skills/**if you want it to apply regardless of workspace root).
packages/react-native-healthkit/ReactNativeHealthkit.podspec:1 - There’s an extra blank line added here that doesn’t appear to serve a purpose and slightly increases diff noise. Consider removing it to keep formatting consistent around the Nitrogen setup section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.