Restore BloodKetones quantity identifier and harden generator against symbol-graph omissions by Copilot · Pull Request #354 · kingstinct/react-native-healthkit

Copilot · 2026-06-03T04:15:37Z

v14 regressed HKQuantityTypeIdentifierBloodKetones: it was absent from generated quantity identifier artifacts, causing synchronous bridge enum conversion failures before Promise construction. This PR restores the identifier and adds a generation guard so header-defined quantity identifiers are preserved even when symbol graph extraction omits them.

Generation pipeline hardening
- scripts/generate-healthkit.ts now backfills quantity identifiers from HKTypeIdentifiers.h comment parsing when they are missing from symbol graph constants.
- Parsed fallback entries now carry iOS availability + legacy/deprecation signal from availability declarations.
Restored generated identifier artifacts
- Reintroduced HKQuantityTypeIdentifierBloodKetones in:
  - src/generated/healthkit.generated.ts
  - src/generated/healthkit-schema.json
- Restored canonical unit mapping (mmol/L) and availability (iOS 8.0) in generated outputs.
Typing alignment
- Extended BloodGlucoseUnit to include 'mmol/L' and mapped Blood Ketones unit typing through that shared unit type.
- Added type-level regression coverage confirming Blood Ketones is present in QuantityTypeIdentifier and has the expected unit typing.
Regression guard
- scripts/verify-healthkit-sdk.ts now asserts HKQuantityTypeIdentifierBloodKetones exists in parsed SDK-backed quantity identifiers.

await queryQuantitySamples('HKQuantityTypeIdentifierBloodKetones', {
  limit: -1,
  filter: { date: { startDate, endDate } },
  unit: 'mmol/L',
})

changeset-bot · 2026-06-03T04:15:41Z

🦋 Changeset detected

Latest commit: 1a88178

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@kingstinct/react-native-healthkit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2026-06-03T04:34:34Z

Open in StackBlitz

npm i https://pkg.pr.new/kingstinct/react-native-healthkit/@kingstinct/react-native-healthkit@354

commit: 1a88178

The backfill loop for symbol-graph-omitted identifiers relies on parseQuantityIdentifierComments to populate commentMap. The old regex required a trailing // comment, so any declaration in HKTypeIdentifiers.h that lacks one (e.g. HKQuantityTypeIdentifierBloodKetones in Xcode 26.2) would silently be skipped, leaving the identifier absent from the schema. Making the comment group optional ((?:\/\/\s*(.*))?$) ensures all HK_EXTERN HKQuantityTypeIdentifier const ... ; declarations are captured regardless of whether they carry an inline comment. https://claude.ai/code/session_01McYUQGPrExiii4ETfdp4y3

…26.2 SDK HKQuantityTypeIdentifierBloodKetones is absent from both the symbol graph and HKTypeIdentifiers.h in the Xcode 26.2 SDK, so neither the symbol graph pass nor the header backfill can recover it. Adds a forcedInclusions field to identifier-overrides.json (and its corresponding type in IdentifierOverrides) that lists identifiers with full metadata (ios, canonicalUnit, aggregationStyle, writeable, legacy). A final pass in parseQuantityIdentifiers inserts any forced entry that neither the symbol graph nor the header provided. HKQuantityTypeIdentifierBloodKetones is seeded with the known metadata (iOS 8.0, mmol/L, Discrete (Arithmetic)) so it will always appear in generated artifacts regardless of SDK version. https://claude.ai/code/session_01McYUQGPrExiii4ETfdp4y3

…nerated files The generator sorts quantity identifiers alphabetically, so BloodGlucose (G) must precede BloodKetones (K). The PR had manually placed BloodKetones first, causing git diff --exit-code to fail after regeneration. Reorder in all four affected locations: - healthkit-schema.json entry order - QuantityTypeIdentifierWriteable union - QUANTITY_IDENTIFIER_IOS_AVAILABILITY object - QUANTITY_IDENTIFIER_CANONICAL_UNITS object - QuantityUnitByIdentifierMap interface https://claude.ai/code/session_01McYUQGPrExiii4ETfdp4y3

Copilot

Pull request overview

This PR addresses a v14 regression where HKQuantityTypeIdentifierBloodKetones was missing from generated HealthKit quantity identifier artifacts, causing enum conversion failures, and hardens the generation pipeline to preserve SDK/header-defined identifiers even when symbol graphs omit constants.

Changes:

Hardened generate-healthkit to backfill missing quantity identifiers from HKTypeIdentifiers.h parsing (including iOS availability + legacy/deprecation signal) and to support explicit forced inclusions.
Restored HKQuantityTypeIdentifierBloodKetones across generated artifacts, including canonical unit mapping (mmol/L) and iOS availability (8.0), and mapped its unit typing via BloodGlucoseUnit.
Added type-level regression coverage ensuring Blood Ketones is present in QuantityTypeIdentifier and its sample unit type narrows as expected.

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/react-native-healthkit/src/types/Units.ts	Extends `BloodGlucoseUnit` to include `'mmol/L'` for restored/generated canonical unit typing.
packages/react-native-healthkit/src/type-tests/generated-typing.ts	Adds type-level regression checks for Blood Ketones identifier presence and unit narrowing.
packages/react-native-healthkit/src/generated/healthkit.generated.ts	Reintroduces `HKQuantityTypeIdentifierBloodKetones` into generated identifier unions, availability map, canonical unit map, and unit-by-identifier typing.
packages/react-native-healthkit/src/generated/healthkit-schema.json	Restores Blood Ketones entry in the generated schema with iOS availability and canonical unit.
packages/react-native-healthkit/scripts/verify-healthkit-sdk.ts	Adds an SDK-backed regression assertion that Blood Ketones is present in parsed quantity identifiers.
packages/react-native-healthkit/scripts/healthkit-schema/identifier-overrides.json	Adds a `forcedInclusions` entry to ensure Blood Ketones can be included even if omitted by both symbol graph and header parsing.
packages/react-native-healthkit/scripts/generate-healthkit.ts	Hardens identifier parsing/generation by backfilling from header parsing and adding forced inclusion support; updates canonical unit typing logic for `'mmol/L'`.
.changeset/thirty-peas-pull.md	Adds a patch changeset for the regression fix.

+  const bloodKetones = schema.quantityIdentifiers.find(
+    (identifier) => identifier.name === 'HKQuantityTypeIdentifierBloodKetones',
+  )
+  assert.ok(
+    bloodKetones,
+    'Pinned SDK should expose HKQuantityTypeIdentifierBloodKetones',
+  )


+"@kingstinct/react-native-healthkit": patch
+---
+
+[WIP] Fix regression of HKQuantityTypeIdentifierBloodKetones in enum


Initial plan

7d7ca9d

Copilot AI assigned Copilot and robertherber Jun 3, 2026

Copilot started work on behalf of robertherber June 3, 2026 04:15 View session

Copilot AI linked an issue Jun 3, 2026 that may be closed by this pull request

v14: HKQuantityTypeIdentifierBloodKetones regressed — missing from enum (was fixed in v13 via #311) #347

Open

Copilot AI added 2 commits June 3, 2026 04:22

fix: restore blood ketones quantity identifier support

8b4e9a3

chore: harden quantity identifier generation fallback

2534196

Copilot AI changed the title ~~[WIP] Fix regression of HKQuantityTypeIdentifierBloodKetones in enum~~ Restore BloodKetones quantity identifier and harden generator against symbol-graph omissions Jun 3, 2026

Copilot AI requested a review from robertherber June 3, 2026 04:27

Copilot finished work on behalf of robertherber June 3, 2026 04:27

Create thirty-peas-pull.md

b46deb0

claude added 3 commits June 3, 2026 04:53

robertherber marked this pull request as ready for review June 3, 2026 05:50

Copilot AI review requested due to automatic review settings June 3, 2026 05:50

Copilot started reviewing on behalf of robertherber June 3, 2026 05:50 View session

Copilot AI reviewed Jun 3, 2026

View reviewed changes

pkuczynski mentioned this pull request Jun 15, 2026

feat: iOS 27 category types (MenopausalState, BleedingAfterMenopause) + generator fix for relocated HKWorkoutActivityType #360

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Restore BloodKetones quantity identifier and harden generator against symbol-graph omissions#354

Restore BloodKetones quantity identifier and harden generator against symbol-graph omissions#354
robertherber with Copilot wants to merge 7 commits into
masterfrom
copilot/fix-hkquantitytypeidentifierbloodketones

Copilot AI commented Jun 3, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Copilot AI commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jun 3, 2026 •

edited

Loading

changeset-bot Bot commented Jun 3, 2026 •

edited

Loading

pkg-pr-new Bot commented Jun 3, 2026 •

edited

Loading